chrome/browser/resources/settings/site_settings/site_list.js - Issue 2249873003: Settings: Fix Site Details subpage routing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_list.js

Issue 2249873003: Settings: Fix Site Details subpage routing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix comment typo Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/site_settings/site_list.js

diff --git a/chrome/browser/resources/settings/site_settings/site_list.js b/chrome/browser/resources/settings/site_settings/site_list.js

index 81e41ec1cc958fe57847b77dad2705e714363f18..0796afdb17b488e22bb236034498a14dadabf193 100644

--- a/chrome/browser/resources/settings/site_settings/site_list.js

+++ b/chrome/browser/resources/settings/site_settings/site_list.js

@@ -402,10 +402,7 @@ Polymer({

if (this.isPolicyControlled_(this.selectedSite.source))

return;

- if (this.allSites)

- settings.navigateTo(settings.Route.SITE_SETTINGS_ALL_DETAILS);

- else

- settings.navigateTo(this.computeCategoryDetailsRoute(this.category));

+ settings.navigateTo(settings.Route.SITE_SETTINGS_SITE_DETAILS);

/**