Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage.html

Issue 2249853008: Reject createImageBitmap promise when the cropRect or resize is too big (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: debugging Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage.html
diff --git a/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage.html b/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage.html
index 982eefe2d6becfb136a04f694108025668ed4023..3e2fc0b0d0a6e346887b3fb755d5ffd06b067b01 100644
--- a/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage.html
+++ b/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage.html
@@ -153,7 +153,8 @@ xhr.onload = function() {
function loaded() {
if (imageLoaded && imageBitmapLoaded && blobLoaded) {
// check all of these elements
- elements = [image, aCanvas, d, testBitmap, blob];
+ // elements = [image, aCanvas, d, testBitmap, blob];
+ elements = [blob];
// wait for callback to finish before each check to ensure synchronous behavior
nextCheck(0);
}
@@ -168,7 +169,7 @@ function nextCheck(elementIndex) {
imageBitmaps = {};
debug("Checking " + jsWrapperClass(element) + ".");
var p1 = createImageBitmap(element).then(function (image) { imageBitmaps.noCrop = image });
- var p2 = createImageBitmap(element, 0, 0, 10, 10).then(function (image) { imageBitmaps.crop = image });
+ /*var p2 = createImageBitmap(element, 0, 0, 10, 10).then(function (image) { imageBitmaps.crop = image });
var p3 = createImageBitmap(element, 5, 5, 10, 10).then(function (image) { imageBitmaps.cropCenter = image });
var p4 = createImageBitmap(element, 10, 10, 10, 10).then(function (image) { imageBitmaps.cropRight = image });
var p5 = createImageBitmap(element, -10, -10, 60, 60).then(function (image) { imageBitmaps.overCrop = image });
@@ -176,8 +177,9 @@ function nextCheck(elementIndex) {
var p7 = createImageBitmap(element, 10, 10, -10, -10).then(function (image) { imageBitmaps.negativeCrop = image });
var p8 = createImageBitmap(element, -30, -30, 30, 30).then(function (image) { imageBitmaps.empty = image });
var p9 = createImageBitmap(element, 40, 30, 30, 30).then(function (image) { imageBitmaps.emptyTwo = image });
- Promise.all([p1, p2, p3, p4, p5, p6, p7, p8, p9]).then(function() {
- checkNoCrop(imageBitmaps.noCrop);
+ Promise.all([p1, p2, p3, p4, p5, p6, p7, p8, p9]).then(function() {*/
+ Promise.all([p1]).then(function() {
+ /*checkNoCrop(imageBitmaps.noCrop);
checkCrop(imageBitmaps.crop);
checkCropCenter(imageBitmaps.cropCenter);
checkCropRight(imageBitmaps.cropRight);
@@ -185,8 +187,8 @@ function nextCheck(elementIndex) {
checkOverCropRight(imageBitmaps.overCropRight);
checkCrop(imageBitmaps.negativeCrop);
checkEmpty(imageBitmaps.empty);
- checkEmpty(imageBitmaps.emptyTwo);
- createImageBitmap(element, 0, 0, Math.pow(10, 6), Math.pow(10, 6)).then(function() {
+ checkEmpty(imageBitmaps.emptyTwo);*/
+ createImageBitmap(element, 0, 0, 0x8000, 0x8000).then(function() {
testFailed('Creating a huge ImageBitmap is resolved unexpectedly.');
finishJSTest();
}, function() {

Powered by Google App Engine
This is Rietveld 408576698