third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage.html - Issue 2249853008: Reject createImageBitmap promise when the cropRect or resize is too big

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage.html

Issue 2249853008: Reject createImageBitmap promise when the cropRect or resize is too big (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage-video.html » ('j') | third_party/WebKit/Source/core/frame/ImageBitmap.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage.html

diff --git a/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage.html b/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage.html

index 982eefe2d6becfb136a04f694108025668ed4023..9a9ae564bb7a68e9d05367d47a14a15ac6886803 100644

--- a/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage.html

+++ b/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage.html

@@ -186,7 +186,7 @@ function nextCheck(elementIndex) {

checkCrop(imageBitmaps.negativeCrop);

checkEmpty(imageBitmaps.empty);

checkEmpty(imageBitmaps.emptyTwo);

- createImageBitmap(element, 0, 0, Math.pow(10, 6), Math.pow(10, 6)).then(function() {

+ createImageBitmap(element, 0, 0, 0x8000, 0x8000).then(function() {

Justin Novosad 2016/08/18 16:42:13 On a 64-bit system it should be possible to alloca

testFailed('Creating a huge ImageBitmap is resolved unexpectedly.');

finishJSTest();

}, function() {