Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2249853002: Add flow-graph generated SIMD array intrinsics. (Closed)

Created:
4 years, 4 months ago by Florian Schneider
Modified:
4 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add flow-graph generated SIMD array intrinsics. Also fix usage of a command-line flag used in tests. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/1a357a4f4081c1e4043cd76ad46ba6303fcd0336

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -21 lines) Patch
M runtime/vm/intrinsifier.cc View 5 chunks +77 lines, -3 lines 0 comments Download
M runtime/vm/method_recognizer.h View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/lib/typed_data/float32x4_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float32x4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float32x4_unbox_phi_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float32x4_unbox_regress_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float64x2_functional_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float64x2_typed_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/int32x4_arithmetic_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/int32x4_bigint_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/int32x4_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/int32x4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/simd_store_to_load_forward_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/simd_type_check_removal.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 4 months ago (2016-08-15 21:42:39 UTC) #2
rmacnak
lgtm
4 years, 4 months ago (2016-08-15 22:25:51 UTC) #3
Florian Schneider
4 years, 4 months ago (2016-08-16 23:17:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a357a4f4081c1e4043cd76ad46ba6303fcd0336 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698