Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2249833003: Convert editing/undo/4063751.html to use w3c test harness (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/undo/4063751.html to use w3c test harness This patch converts "editing/undo/4063751.html" to use w3c test harness to simplify test script for improving readability. This patch also renames it to "redo_rebalance_whitespace.html" to provide a hint what this test script verifies. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/14da44c0d317243b314d97b04b57b47c9888f127 Cr-Commit-Position: refs/heads/master@{#412749}

Patch Set 1 : 2016-08-16T15:22:16 #

Patch Set 2 : 2016-08-17T10:59:55 #

Messages

Total messages: 30 (16 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-08-16 07:23:47 UTC) #5
Xiaocheng
Please remove redo-style.html from this patch. It's already converted, iirc.
4 years, 4 months ago (2016-08-17 01:45:47 UTC) #8
yosin_UTC9
On 2016/08/17 at 01:45:47, xiaochengh wrote: > Please remove redo-style.html from this patch. It's already ...
4 years, 4 months ago (2016-08-17 02:03:49 UTC) #11
Xiaocheng
On 2016/08/17 at 02:03:49, yosin wrote: > On 2016/08/17 at 01:45:47, xiaochengh wrote: > > ...
4 years, 4 months ago (2016-08-17 02:32:33 UTC) #14
yosin_UTC9
On 2016/08/17 at 02:32:33, xiaochengh wrote: > On 2016/08/17 at 02:03:49, yosin wrote: > > ...
4 years, 4 months ago (2016-08-17 04:36:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249833003/20001
4 years, 4 months ago (2016-08-17 04:36:59 UTC) #18
yosin_UTC9
On 2016/08/17 at 04:36:18, Yosi_UTC9 wrote: > On 2016/08/17 at 02:32:33, xiaochengh wrote: > > ...
4 years, 4 months ago (2016-08-17 04:37:33 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/239579)
4 years, 4 months ago (2016-08-17 04:40:11 UTC) #21
yosin_UTC9
On 2016/08/17 at 04:37:33, Yosi_UTC9 wrote: > On 2016/08/17 at 04:36:18, Yosi_UTC9 wrote: > > ...
4 years, 4 months ago (2016-08-17 04:48:51 UTC) #22
yosin_UTC9
PTAL; presubmit bug is resolved.
4 years, 4 months ago (2016-08-18 02:11:34 UTC) #23
Xiaocheng
lgtm
4 years, 4 months ago (2016-08-18 02:13:20 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249833003/20001
4 years, 4 months ago (2016-08-18 02:13:49 UTC) #27
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 05:35:51 UTC) #28
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 05:37:38 UTC) #30
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/14da44c0d317243b314d97b04b57b47c9888f127
Cr-Commit-Position: refs/heads/master@{#412749}

Powered by Google App Engine
This is Rietveld 408576698