Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 2249833002: Reset analysis driver after incremental changes. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reset analysis driver after incremental changes. Otherwise we might continue computing computing results using stale values of other results. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9aca4cc76baebd331289863df9b3d402ba914cd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 4 months ago (2016-08-15 20:21:22 UTC) #1
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-08-15 20:30:37 UTC) #2
scheglov
4 years, 4 months ago (2016-08-15 20:35:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9aca4cc76baebd331289863df9b3d402ba914cd9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698