Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: net/tools/quic/quic_simple_server_stream_test.cc

Issue 2249813002: Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_simple_server_session_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_simple_server_stream_test.cc
diff --git a/net/tools/quic/quic_simple_server_stream_test.cc b/net/tools/quic/quic_simple_server_stream_test.cc
index 2a0de32acfa60e0a0fd4b24916ef8580d22cdc07..0c6039d229309c3d2bc848113929d1ac94a56fe2 100644
--- a/net/tools/quic/quic_simple_server_stream_test.cc
+++ b/net/tools/quic/quic_simple_server_stream_test.cc
@@ -190,7 +190,6 @@ class QuicSimpleServerStreamTest
crypto_config_.get(),
&compressed_certs_cache_),
body_("hello world") {
- FLAGS_quic_always_log_bugs_for_tests = true;
SpdyHeaderBlock request_headers;
request_headers[":host"] = "";
request_headers[":authority"] = "www.google.com";
@@ -468,9 +467,9 @@ TEST_P(QuicSimpleServerStreamTest, SendReponseWithPushResources) {
TEST_P(QuicSimpleServerStreamTest, PushResponseOnClientInitiatedStream) {
// Calling PushResponse() on a client initialted stream is never supposed to
// happen.
- EXPECT_DFATAL(stream_->PushResponse(SpdyHeaderBlock()),
- "Client initiated stream"
- " shouldn't be used as promised stream.");
+ EXPECT_QUIC_BUG(stream_->PushResponse(SpdyHeaderBlock()),
+ "Client initiated stream"
+ " shouldn't be used as promised stream.");
}
TEST_P(QuicSimpleServerStreamTest, PushResponseOnServerInitiatedStream) {
« no previous file with comments | « net/tools/quic/quic_simple_server_session_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698