Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: net/tools/quic/quic_dispatcher_test.cc

Issue 2249813002: Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/end_to_end_test.cc ('k') | net/tools/quic/quic_simple_server_session_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_dispatcher_test.cc
diff --git a/net/tools/quic/quic_dispatcher_test.cc b/net/tools/quic/quic_dispatcher_test.cc
index 07df1e6830971a8b8d0c5a2ec7bb0a93bdfba742..7957ec0c2fda2fc98f387a13d6c8b52f641b3372 100644
--- a/net/tools/quic/quic_dispatcher_test.cc
+++ b/net/tools/quic/quic_dispatcher_test.cc
@@ -727,7 +727,6 @@ TEST_P(QuicDispatcherStatelessRejectTest, CheapRejects) {
TEST_P(QuicDispatcherStatelessRejectTest, BufferNonChlo) {
FLAGS_quic_use_cheap_stateless_rejects = true;
- FLAGS_quic_always_log_bugs_for_tests = true;
CreateTimeWaitListManager();
const IPEndPoint client_address(net::test::Loopback4(), 1);
@@ -751,7 +750,7 @@ TEST_P(QuicDispatcherStatelessRejectTest, BufferNonChlo) {
if (first_packet_dropped) {
// Never do stateless reject while
// FLAGS_quic_buffer_packet_till_chlo is off.
- EXPECT_DFATAL(
+ EXPECT_QUIC_BUG(
ProcessPacket(client_address, connection_id, true, false,
"NOT DATA FOR A CHLO"),
"Have to drop packet because buffering non-chlo packet is "
« no previous file with comments | « net/tools/quic/end_to_end_test.cc ('k') | net/tools/quic/quic_simple_server_session_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698