Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2311)

Unified Diff: net/quic/core/quic_spdy_stream_test.cc

Issue 2249813002: Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_session_test.cc ('k') | net/quic/core/quic_stream_sequencer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_spdy_stream_test.cc
diff --git a/net/quic/core/quic_spdy_stream_test.cc b/net/quic/core/quic_spdy_stream_test.cc
index cad7e8b60fa39d1ed67d81d400a457518f3edcfe..97a193253293e09b48a76207bb6cdf2f1d743e59 100644
--- a/net/quic/core/quic_spdy_stream_test.cc
+++ b/net/quic/core/quic_spdy_stream_test.cc
@@ -67,7 +67,6 @@ class TestStream : public QuicSpdyStream {
class QuicSpdyStreamTest : public ::testing::TestWithParam<QuicVersion> {
public:
QuicSpdyStreamTest() {
- FLAGS_quic_always_log_bugs_for_tests = true;
headers_[":host"] = "www.google.com";
headers_[":path"] = "/index.hml";
headers_[":scheme"] = "https";
@@ -996,8 +995,8 @@ TEST_P(QuicSpdyStreamTest, WritingTrailersAfterFIN) {
// Writing Trailers should fail, as the FIN has already been sent.
// populated with the number of body bytes written.
- EXPECT_DFATAL(stream_->WriteTrailers(SpdyHeaderBlock(), nullptr),
- "Trailers cannot be sent after a FIN");
+ EXPECT_QUIC_BUG(stream_->WriteTrailers(SpdyHeaderBlock(), nullptr),
+ "Trailers cannot be sent after a FIN");
}
} // namespace
« no previous file with comments | « net/quic/core/quic_session_test.cc ('k') | net/quic/core/quic_stream_sequencer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698