components/autofill/core/browser/autofill_external_delegate.h - Issue 2249773002: Scan card holder name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate.h

Issue 2249773002: Scan card holder name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/autofill_external_delegate.h

diff --git a/components/autofill/core/browser/autofill_external_delegate.h b/components/autofill/core/browser/autofill_external_delegate.h

index 37925fb140f09c843eeb1cfce9251ebab56a0847..0d9789c03e0bfafce61e87b6a2cf2cfa52b02c66 100644

--- a/components/autofill/core/browser/autofill_external_delegate.h

+++ b/components/autofill/core/browser/autofill_external_delegate.h

@@ -91,7 +91,8 @@ class AutofillExternalDelegate : public AutofillPopupDelegate {

FillCreditCardForm);

// Called when a credit card is scanned using device camera.

- void OnCreditCardScanned(const base::string16& card_number,

+ void OnCreditCardScanned(const base::string16& card_holder_name,

Evan Stade 2016/08/16 00:33:35 is there a reason this doesn't just take a CreditC

please use gerrit instead 2016/08/16 22:03:18 No reason. Changed to take a card.

Evan Stade 2016/08/17 06:30:57 nice

+ const base::string16& card_number,

int expiration_month,

int expiration_year);