Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc

Issue 2249773002: Scan card holder name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass CreditCard, don't alter the constructor. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
diff --git a/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc b/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
index ff0beff95e480505819ee155c5714cdd4da2e2b3..13cc10a646c65aa52dc5e3ac61121b122782e75b 100644
--- a/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
+++ b/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
@@ -12,6 +12,8 @@
#include "base/memory/ptr_util.h"
#include "chrome/browser/ui/android/view_android_helper.h"
#include "chrome/browser/ui/autofill/credit_card_scanner_view_delegate.h"
+#include "components/autofill/core/browser/credit_card.h"
+#include "components/autofill/core/browser/field_types.h"
#include "content/public/browser/android/content_view_core.h"
#include "jni/CreditCardScanner_jni.h"
#include "ui/android/view_android.h"
@@ -67,12 +69,15 @@ void CreditCardScannerViewAndroid::ScanCancelled(
void CreditCardScannerViewAndroid::ScanCompleted(
JNIEnv* env,
const JavaParamRef<jobject>& object,
+ const JavaParamRef<jstring>& card_holder_name,
const JavaParamRef<jstring>& card_number,
jint expiration_month,
jint expiration_year) {
- delegate_->ScanCompleted(
- base::android::ConvertJavaStringToUTF16(env, card_number),
+ CreditCard card(base::android::ConvertJavaStringToUTF16(env, card_number),
static_cast<int>(expiration_month), static_cast<int>(expiration_year));
+ card.SetRawInfo(CREDIT_CARD_NAME_FULL,
+ base::android::ConvertJavaStringToUTF16(env, card_holder_name));
+ delegate_->ScanCompleted(card);
}
void CreditCardScannerViewAndroid::Show() {

Powered by Google App Engine
This is Rietveld 408576698