[DevTools] Fill ExceptionDetails with more details, unify usage across protocol.

third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 230 matching lines @@
          * @param {!RuntimeAgent.ScriptId=} scriptId
          * @param {?RuntimeAgent.ExceptionDetails=} exceptionDetails
          * @this {WebInspector.ScriptSnippetModel}
          */
         function compileCallback(scriptId, exceptionDetails)
         {
             var mapping = this._mappingForTarget.get(target);
             if (mapping.evaluationIndex(uiSourceCode) !== evaluationIndex)
                 return;
 
-            var script = /** @type {!WebInspector.Script} */(executionContext.debuggerModel.scriptForId(scriptId || exceptionDetails.scriptId));
+            var script = /** @type {!WebInspector.Script} */(executionContext.debuggerModel.scriptForId(/** @type {string} */ (scriptId || exceptionDetails.scriptId)));
             mapping._addScript(script, uiSourceCode);
             if (!scriptId) {
-                this._printRunOrCompileScriptResultFailure(target, exceptionDetails, evaluationUrl);
+                this._printRunOrCompileScriptResultFailure(target, /** @type {!RuntimeAgent.ExceptionDetails} */ (exceptionDetails), evaluationUrl);
                 return;
             }
 
             var breakpointLocations = this._removeBreakpoints(uiSourceCode);
             this._restoreBreakpoints(uiSourceCode, breakpointLocations);
 
             this._runScript(scriptId, executionContext, evaluationUrl);
         }
     },
 
@@ skipping 43 matching lines @@
             [result],
             undefined,
             undefined,
             undefined,
             scriptId);
         target.consoleModel.addMessage(consoleMessage);
     },
 
     /**
      * @param {!WebInspector.Target} target
-     * @param {?RuntimeAgent.ExceptionDetails=} exceptionDetails
+     * @param {!RuntimeAgent.ExceptionDetails} exceptionDetails
      * @param {?string=} sourceURL
      */
     _printRunOrCompileScriptResultFailure: function(target, exceptionDetails, sourceURL)
     {
-        var consoleMessage = new WebInspector.ConsoleMessage(
-            target,
-            exceptionDetails.source,
-            WebInspector.ConsoleMessage.MessageLevel.Error,
-            exceptionDetails.text,
-            undefined,
-            sourceURL,
-            exceptionDetails.lineNumber,
-            exceptionDetails.columnNumber,
-            undefined,
-            undefined,
-            exceptionDetails.stackTrace,
-            undefined,
-            undefined,
-            exceptionDetails.stackTrace ? undefined : exceptionDetails.scriptId);
-        target.consoleModel.addMessage(consoleMessage);
+        target.consoleModel.addMessage(WebInspector.ConsoleMessage.fromException(target, exceptionDetails, undefined, undefined, sourceURL || undefined));
     },
 
     /**
      * @param {!WebInspector.UISourceCode} uiSourceCode
      * @return {!Array.<!{breakpoint: !WebInspector.BreakpointManager.Breakpoint, uiLocation: !WebInspector.UILocation}>}
      */
     _removeBreakpoints: function(uiSourceCode)
     {
         var breakpointLocations = WebInspector.breakpointManager.breakpointLocationsForUISourceCode(uiSourceCode);
         for (var i = 0; i < breakpointLocations.length; ++i)
@@ skipping 335 matching lines @@
         this._model.deleteScriptSnippet(url);
     },
 
     __proto__: WebInspector.ContentProviderBasedProject.prototype
 }
 
 /**
  * @type {!WebInspector.ScriptSnippetModel}
  */
 WebInspector.scriptSnippetModel = new WebInspector.ScriptSnippetModel(WebInspector.workspace);