third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h - Issue 2249743002: [DevTools] Rename entities in js_protocol, remove deprecated ones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

Issue 2249743002: [DevTools] Rename entities in js_protocol, remove deprecated ones. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

index 28a54c1c33d924ba4d8e0b5b73c7b90b1770cd0b..d08a0b63311a83a40e6832aeceef1f098d02604d 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

@@ -62,7 +62,7 @@ public:

const String16& expression,

const Maybe<String16>& objectGroup,

const Maybe<bool>& includeCommandLineAPI,

- const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole,

+ const Maybe<bool>& silent,

const Maybe<int>& executionContextId,

const Maybe<bool>& returnByValue,

const Maybe<bool>& generatePreview,

@@ -78,7 +78,7 @@ public:

const String16& objectId,

const String16& expression,

const Maybe<protocol::Array<protocol::Runtime::CallArgument>>& optionalArguments,

- const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole,

+ const Maybe<bool>& silent,

const Maybe<bool>& returnByValue,

const Maybe<bool>& generatePreview,

const Maybe<bool>& userGesture,

@@ -94,7 +94,7 @@ public:

Maybe<protocol::Array<protocol::Runtime::InternalPropertyDescriptor>>* internalProperties,

Maybe<protocol::Runtime::ExceptionDetails>*) override;

void releaseObjectGroup(ErrorString*, const String16& objectGroup) override;

- void run(ErrorString*) override;

+ void runIfWaitingForDebugger(ErrorString*) override;

void setCustomObjectFormatterEnabled(ErrorString*, bool) override;

void discardConsoleEntries(ErrorString*) override;

void compileScript(ErrorString*,

@@ -108,7 +108,7 @@ public:

const String16&,

const Maybe<int>& executionContextId,

const Maybe<String16>& objectGroup,

- const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole,

+ const Maybe<bool>& silent,

const Maybe<bool>& includeCommandLineAPI,

const Maybe<bool>& returnByValue,

const Maybe<bool>& generatePreview,