Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2249703002: add gm that exercises compose shader allocations (Closed)

Created:
4 years, 4 months ago by caryclark
Modified:
4 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add gm that exercises compose shader allocations This gm triggers the assert in SkSmallAllocator.h commented out by this CL. PDFium constructs shaders that resemble the GM. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249703002 Committed: https://skia.googlesource.com/skia/+/c2ad65e94de8c7c178699a2cb211d3a768bfdb90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -4 lines) Patch
M gm/composeshader.cpp View 1 chunk +38 lines, -0 lines 0 comments Download
M src/core/SkSmallAllocator.h View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
caryclark
4 years, 4 months ago (2016-08-15 18:12:46 UTC) #2
reed1
lgtm
4 years, 4 months ago (2016-08-15 18:36:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249703002/1
4 years, 4 months ago (2016-08-15 18:45:01 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 19:03:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c2ad65e94de8c7c178699a2cb211d3a768bfdb90

Powered by Google App Engine
This is Rietveld 408576698