Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2249693002: Remove old SwiftShader files and reference. (Closed)

Created:
4 years, 4 months ago by capn
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, kylechar, Torne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old SwiftShader license and update credits. There were still files from prior to the open-sourcing in //third_party/swiftshader, and gl_init's GPY build file should not reference the old include directory which contained the license key registration which is no longer needed since https://codereview.chromium.org/2231913002/. Also the about:credits script is updated with SwiftShader's license information. BUG=630728 TBR=ben@chromium.org Committed: https://crrev.com/d37d668d489bdd1c8a678227386c0988fe4ea85b Cr-Commit-Position: refs/heads/master@{#412061}

Patch Set 1 #

Patch Set 2 : Also update about:credits script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
D third_party/swiftshader/LICENSE View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/swiftshader/README.chromium View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/licenses.py View 1 1 chunk +7 lines, -0 lines 0 comments Download
M ui/gl/init/gl_init.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
capn
PTAL
4 years, 4 months ago (2016-08-15 19:39:12 UTC) #9
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-15 19:43:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249693002/20001
4 years, 4 months ago (2016-08-15 21:38:56 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/238357)
4 years, 4 months ago (2016-08-15 21:43:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249693002/20001
4 years, 4 months ago (2016-08-15 21:52:32 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-15 21:57:23 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 22:06:18 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d37d668d489bdd1c8a678227386c0988fe4ea85b
Cr-Commit-Position: refs/heads/master@{#412061}

Powered by Google App Engine
This is Rietveld 408576698