Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2249683003: Fix some TSAN problems in Activity Tracker/Analyzer. (Closed)

Created:
4 years, 4 months ago by bcwhite
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some TSAN problems in Activity Tracker/Analyzer. BUG= Committed: https://crrev.com/744f203d6ab20ceaeae9ceb42766bf90f6b68bc2 Cr-Commit-Position: refs/heads/master@{#412284}

Patch Set 1 #

Patch Set 2 : fixed compile problem #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M base/debug/activity_analyzer_unittest.cc View 1 5 chunks +9 lines, -6 lines 1 comment Download
M base/debug/activity_tracker.cc View 5 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tommycli
lgtm thanks
4 years, 4 months ago (2016-08-16 17:32:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249683003/20001
4 years, 4 months ago (2016-08-16 17:48:07 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 17:52:06 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/744f203d6ab20ceaeae9ceb42766bf90f6b68bc2 Cr-Commit-Position: refs/heads/master@{#412284}
4 years, 4 months ago (2016-08-16 17:54:41 UTC) #11
Alexander Potapenko
4 years, 2 months ago (2016-10-14 10:07:33 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/2249683003/diff/20001/base/debug/activity_ana...
File base/debug/activity_analyzer_unittest.cc (right):

https://codereview.chromium.org/2249683003/diff/20001/base/debug/activity_ana...
base/debug/activity_analyzer_unittest.cc:124:
SPIN_FOR_1_SECOND_OR_UNTIL_TRUE(ready_.load(std::memory_order_relaxed));
You're waiting for another thread here, but do not create an actual
happens-before arc.
Accesses to ready_ should be acquire/release instead of relaxed.

Powered by Google App Engine
This is Rietveld 408576698