Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2249673006: Merge M52: Ignore desktop creation errors in the sandbox. (Closed)

Created:
4 years, 4 months ago by Will Harris
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Merge M52: Ignore desktop creation errors in the sandbox. This patch reverts the original behaviour that we ignore errors when creating the alternative desktop. Also this includes a change to try and open the window station with lower privileges if the first request fails, which works fine for operation but not for testing. Finally it logs any failure to create the desktop as a warning in the existing histogram. CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng TEST=1. Test on Windows 7 2. Download PSTools from https://technet.microsoft.com/en-us/sysinternals/pstools.aspx 3. Run cmd.exe as an administrator 4. Run the command 'psexec -s -i 0 c:\path\to\chrome.exe' 5. Click on the icon which indicates there a message on the service desktop. This will switch to the service desktop where chrome is running. 6. Verify that the browser is useable BUG=615396, 638516 Review-Url: https://codereview.chromium.org/2193603004 Cr-Commit-Position: refs/heads/master@{#409229} (cherry picked from commit 37dd5680ab4edbbf730e8540825b9caa8db0d911) Review URL: https://codereview.chromium.org/2243543002 . Cr-Commit-Position: refs/branch-heads/2785@{#565} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} (cherry picked from commit 6e54a7bc46d5451ef1019fa243ec964aa9fb4179) Committed: https://chromium.googlesource.com/chromium/src/+/72d84be035096e74aab4ebb168d2aa221e6bf726

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M content/common/sandbox_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/win/src/window.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Will Harris
4 years, 4 months ago (2016-08-17 17:28:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
72d84be035096e74aab4ebb168d2aa221e6bf726.

Powered by Google App Engine
This is Rietveld 408576698