third_party/WebKit/Source/core/events/MouseEvent.cpp - Issue 2249663002: Fixed & refactored mouse event firing at gesture context menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/MouseEvent.cpp

Issue 2249663002: Fixed & refactored mouse event firing at gesture context menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed tests, removed one overfitting Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position-expected.txt ('k') | third_party/WebKit/Source/core/input/EventHandler.h » ('j') | third_party/WebKit/Source/core/input/GestureManager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/events/MouseEvent.cpp

diff --git a/third_party/WebKit/Source/core/events/MouseEvent.cpp b/third_party/WebKit/Source/core/events/MouseEvent.cpp

index 77e22e2fbff9203f84dcd29a7b5c229a2ed92978..13493e977c5ebb800a8e3809f0476d624279f093 100644

--- a/third_party/WebKit/Source/core/events/MouseEvent.cpp

+++ b/third_party/WebKit/Source/core/events/MouseEvent.cpp

@@ -39,8 +39,6 @@ MouseEvent* MouseEvent::create(ScriptState* scriptState, const AtomicString& typ

MouseEvent* MouseEvent::create(const AtomicString& eventType, AbstractView* view, const PlatformMouseEvent& event, int detail, Node* relatedTarget)

{

- ASSERT(event.type() == PlatformEvent::MouseMoved || event.button() != NoButton);

bool isMouseEnterOrLeave = eventType == EventTypeNames::mouseenter || eventType == EventTypeNames::mouseleave;

bool isCancelable = !isMouseEnterOrLeave;

bool isBubbling = !isMouseEnterOrLeave;