Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: tests/language/mixin_bound_test.dart

Issue 224963016: Fix for 15979- class aliases now have missing concrete members warnings generated on them. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/mixin_bound_test.dart
diff --git a/tests/language/mixin_bound_test.dart b/tests/language/mixin_bound_test.dart
index a4d7d46945ac40b8ac61f328bb0b7afdbecf4aac..d9d49ea3aba424aaee0feffcf1a5c4c42b13bf13 100644
--- a/tests/language/mixin_bound_test.dart
+++ b/tests/language/mixin_bound_test.dart
@@ -101,29 +101,29 @@ abstract class MultiplicationWithStringConversion<E extends ExpressionWithString
// import 'multiplicationEvaluator.dart';
// import 'stringConverter.dart';
-class Expression =
- AbstractExpression with ExpressionWithEval, ExpressionWithStringConversion;
+class Expression = /// 00: static type warning
rmacnak 2014/04/07 22:24:18 Should be declared abstract.
jwren 2014/04/07 22:34:41 Got it, marking the alias as abstract the warning
+ AbstractExpression with ExpressionWithEval, ExpressionWithStringConversion; /// 00: ok
-class Addition =
- AbstractAddition<Expression> with AdditionWithEval<Expression>,
- AdditionWithStringConversion<Expression> implements Expression;
+class Addition = /// 00: ok
rmacnak 2014/04/07 22:24:18 We don't expect warnings here.
jwren 2014/04/07 22:34:41 Correct. The special comment indicates that for t
+ AbstractAddition<Expression> with AdditionWithEval<Expression>, /// 00: ok
+ AdditionWithStringConversion<Expression> implements Expression; /// 00: ok
-class Subtraction =
- AbstractSubtraction<Expression> with SubtractionWithEval<Expression>,
- SubtractionWithStringConversion<Expression> implements Expression;
+class Subtraction = /// 00: ok
rmacnak 2014/04/07 22:24:18 We don't expect warnings here.
+ AbstractSubtraction<Expression> with SubtractionWithEval<Expression>, /// 00: ok
+ SubtractionWithStringConversion<Expression> implements Expression; /// 00: ok
-class Number =
- AbstractNumber with NumberWithEval,
- NumberWithStringConversion implements Expression;
+class Number = /// 00: ok
rmacnak 2014/04/07 22:24:18 We don't expect warnings here.
+ AbstractNumber with NumberWithEval, /// 00: ok
+ NumberWithStringConversion implements Expression; /// 00: ok
-class Multiplication =
- AbstractMultiplication<Expression> with MultiplicationWithEval<Expression>,
- MultiplicationWithStringConversion<Expression> implements Expression;
+class Multiplication = /// 00: ok
rmacnak 2014/04/07 22:24:18 We don't expect warnings here.
+ AbstractMultiplication<Expression> with MultiplicationWithEval<Expression>, /// 00: ok
+ MultiplicationWithStringConversion<Expression> implements Expression; /// 00: ok
void main() {
- Expression e = new Multiplication(new Addition(new Number(4), new Number(2)),
- new Subtraction(new Number(10), new Number(7)));
- Expect.equals('((4 + 2)) * (10 - 7)) = 18', '$e = ${e.eval}');
+ Expression e = new Multiplication(new Addition(new Number(4), new Number(2)), /// 00: ok
+ new Subtraction(new Number(10), new Number(7))); /// 00: ok
+ Expect.equals('((4 + 2)) * (10 - 7)) = 18', '$e = ${e.eval}'); /// 00: ok
}

Powered by Google App Engine
This is Rietveld 408576698