Issue 2249613002: Measure <body onselectionchange> content attribute

Issue 2249613002: Measure <body onselectionchange> content attribute (Closed)

Created:
4 years, 4 months ago by foolip

Modified:
4 years, 4 months ago

Reviewers:
Mike West

CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Measure <body onselectionchange> content attribute This is the only event handler attribute on body that forwards to the document instead of the window. WebKit also has it as an IDL attribute, while Edge and Gecko don't have onselectionchange on body at all. This is in order to inform the spec: https://github.com/w3c/selection-api/issues/54#issuecomment-239574361 R=tkent@chromium.org,isherman@chromium.org Committed: https://crrev.com/9d50359eabc1cf54bfc52be4cf4e19b8b4dceb9f Cr-Commit-Position: refs/heads/master@{#412824}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
M	third_party/WebKit/Source/core/frame/UseCounter.h	View	1	3 chunks	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/HTMLBodyElement.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 15 (6 generated)

foolip

Oops, checked both jochen and mkwst, somehow failed to pick mkwst as intended :)

4 years, 4 months ago (2016-08-15 12:07:52 UTC) #5

foolip

On 2016/08/17 20:42:00, foolip wrote: > Ping Mike@? No@ :)

4 years, 4 months ago (2016-08-17 20:42:11 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249613002/20001

4 years, 4 months ago (2016-08-18 12:28:02 UTC) #12

commit-bot: I haz the power

4 years, 4 months ago (2016-08-18 14:54:10 UTC) #15

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/9d50359eabc1cf54bfc52be4cf4e19b8b4dceb9f
Cr-Commit-Position: refs/heads/master@{#412824}