Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2249593002: binding: ExceptionState no longer takes |creationContext|. (Closed)

Created:
4 years, 4 months ago by Yuki
Modified:
4 years, 4 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: ExceptionState no longer takes |creationContext|. Since V8ThrowException no longer takes |creationContext|, there is no need for ExceptionState to take |creationContext|, too. This CL also adds new constructors of ExceptionState that take v8::Isolate* as the first argument. These new constructors will be used later. BUG=618672 Committed: https://crrev.com/611954a8adb1321a8cbf21b1065f62f3504a3119 Cr-Commit-Position: refs/heads/master@{#412183}

Patch Set 1 #

Patch Set 2 : Fixed a compile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -13 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ExceptionState.h View 1 2 chunks +24 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Yuki
Could you review this CL?
4 years, 4 months ago (2016-08-15 09:49:20 UTC) #2
haraken
LGTM
4 years, 4 months ago (2016-08-15 14:23:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249593002/20001
4 years, 4 months ago (2016-08-16 07:11:45 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 07:16:10 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 07:18:11 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/611954a8adb1321a8cbf21b1065f62f3504a3119
Cr-Commit-Position: refs/heads/master@{#412183}

Powered by Google App Engine
This is Rietveld 408576698