Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2249583002: Revert "Enable ash window cycle UI by default." (Closed)

Created:
4 years, 4 months ago by hiroshige
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, kalyank, sadrul, Matt Giuca, asvitkine+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Enable ash window cycle UI by default." Reason for revert: Suspected to cause crbug.com/637671: failures in ash_unittests on Linux Chromium OS ASan LSan Tests (1) Original issue's description: > Enable ash window cycle UI by default. > > I removed the enable flag without replacing it with a disable flag > because I don't foresee a need for individuals to disable this feature. > In the case that we decide against launching, this patch should be > reverted (which is the same thing we'd have to do if we changed it to > a disable flag). > > BUG=626111 > Committed: https://crrev.com/f7648dcc7f7474f89028af0e4643678a6a97a846 > Cr-Commit-Position: refs/heads/master@{#411909} This reverts commit f7648dcc7f7474f89028af0e4643678a6a97a846. BUG=626111, 637671 TBR=jamescook@chromium.org,varkha@chromium.org,sky@chromium.org,estade@chromium.org Committed: https://crrev.com/9ab053f5fdca88cb43cd1a70a06fba521d1f8ece Cr-Commit-Position: refs/heads/master@{#411949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -110 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M ash/common/ash_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/ash_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/wm/window_cycle_controller.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M ash/common/wm/window_cycle_list.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/common/wm/window_cycle_list.cc View 6 chunks +10 lines, -38 lines 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 12 chunks +83 lines, -33 lines 0 comments Download
M ash/wm/window_mirror_view.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/app_list/presenter/app_list_presenter_impl.cc View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249583002/1
4 years, 4 months ago (2016-08-15 08:08:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 08:57:31 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 08:59:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ab053f5fdca88cb43cd1a70a06fba521d1f8ece
Cr-Commit-Position: refs/heads/master@{#411949}

Powered by Google App Engine
This is Rietveld 408576698