Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2249563002: CsutomElements: adoptedCallback unit test (Closed)

Created:
4 years, 4 months ago by davaajav
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CsutomElements: adoptedCallback unit test adoptedCallback test https://dom.spec.whatwg.org/#concept-node-adopt BUG=594918 Committed: https://crrev.com/71327934c72fb374ed60804a04c0627a9bdce588 Cr-Commit-Position: refs/heads/master@{#412179}

Patch Set 1 #

Patch Set 2 : misspell correction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
davaajav
PTL
4 years, 4 months ago (2016-08-15 04:36:47 UTC) #2
kojii
lgtm
4 years, 4 months ago (2016-08-15 05:51:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249563002/1
4 years, 4 months ago (2016-08-16 01:56:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/238580)
4 years, 4 months ago (2016-08-16 02:03:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249563002/20001
4 years, 4 months ago (2016-08-16 02:38:59 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/238612)
4 years, 4 months ago (2016-08-16 02:45:21 UTC) #12
dominicc (has gone to gerrit)
lgtm
4 years, 4 months ago (2016-08-16 06:22:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249563002/20001
4 years, 4 months ago (2016-08-16 06:22:27 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 06:26:03 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 06:29:09 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/71327934c72fb374ed60804a04c0627a9bdce588
Cr-Commit-Position: refs/heads/master@{#412179}

Powered by Google App Engine
This is Rietveld 408576698