Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 2249533003: [Platform] Enable to get a partial data of SharedBuffer (Closed)

Created:
4 years, 4 months ago by peria
Modified:
4 years, 4 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This CL creates a method to get a partial data of SharedBuffer. This new method allows us to read a part of a buffer with specifying starting position and length as a copy. BUG=634935 Committed: https://crrev.com/4b42aa218b8ebeef9ef8eef3109df7d89214d38d Cr-Commit-Position: refs/heads/master@{#411951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -15 lines) Patch
M third_party/WebKit/Source/platform/SharedBuffer.h View 2 chunks +15 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/SharedBuffer.cpp View 1 chunk +15 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/SharedBufferTest.cpp View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
peria
PTL.
4 years, 4 months ago (2016-08-15 07:25:08 UTC) #3
haraken
LGTM
4 years, 4 months ago (2016-08-15 07:39:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249533003/1
4 years, 4 months ago (2016-08-15 08:06:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 09:25:31 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 09:27:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b42aa218b8ebeef9ef8eef3109df7d89214d38d
Cr-Commit-Position: refs/heads/master@{#411951}

Powered by Google App Engine
This is Rietveld 408576698