content/browser/renderer_host/p2p/socket_host_udp.cc - Issue 2249473002: Remove use of stl_util's STLDeleteContainerPairSecondPointers from content/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_host_udp.cc

Issue 2249473002: Remove use of stl_util's STLDeleteContainerPairSecondPointers from content/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/p2p/socket_host_udp.h ('k') | content/browser/renderer_host/p2p/socket_host_udp_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/p2p/socket_host_udp.cc

diff --git a/content/browser/renderer_host/p2p/socket_host_udp.cc b/content/browser/renderer_host/p2p/socket_host_udp.cc

index 2eb3579b99800addbe0f85a0f310ae708d1b85cc..7d511c88fec2c53fda620b794dae94d42b91b7da 100644

--- a/content/browser/renderer_host/p2p/socket_host_udp.cc

+++ b/content/browser/renderer_host/p2p/socket_host_udp.cc

@@ -401,11 +401,12 @@ void P2PSocketHostUdp::HandleSendResult(uint64_t packet_id,

P2PSendPacketMetrics(packet_id, transport_sequence_number, send_time)));

}

-P2PSocketHost* P2PSocketHostUdp::AcceptIncomingTcpConnection(

- const net::IPEndPoint& remote_address, int id) {

+std::unique_ptr<P2PSocketHost> P2PSocketHostUdp::AcceptIncomingTcpConnection(

+ const net::IPEndPoint& remote_address,

+ int id) {

NOTREACHED();

OnError();

- return NULL;

+ return nullptr;

}

bool P2PSocketHostUdp::SetOption(P2PSocketOption option, int value) {