Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: content/browser/child_process_security_policy_impl.cc

Issue 2249473002: Remove use of stl_util's STLDeleteContainerPairSecondPointers from content/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/child_process_security_policy_impl.cc
diff --git a/content/browser/child_process_security_policy_impl.cc b/content/browser/child_process_security_policy_impl.cc
index e9ffa3dee36540094f140a2a47df80d4caf6cfaa..901a95eb31c930895f16499515dca744bc39d978 100644
--- a/content/browser/child_process_security_policy_impl.cc
+++ b/content/browser/child_process_security_policy_impl.cc
@@ -11,8 +11,8 @@
#include "base/files/file_path.h"
#include "base/logging.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/metrics/histogram.h"
-#include "base/stl_util.h"
#include "base/strings/string_util.h"
#include "build/build_config.h"
#include "content/browser/site_instance_impl.h"
@@ -313,8 +313,6 @@ ChildProcessSecurityPolicyImpl::ChildProcessSecurityPolicyImpl() {
ChildProcessSecurityPolicyImpl::~ChildProcessSecurityPolicyImpl() {
web_safe_schemes_.clear();
pseudo_schemes_.clear();
- base::STLDeleteContainerPairSecondPointers(security_state_.begin(),
- security_state_.end());
security_state_.clear();
}
@@ -341,12 +339,7 @@ void ChildProcessSecurityPolicyImpl::AddWorker(int child_id,
void ChildProcessSecurityPolicyImpl::Remove(int child_id) {
base::AutoLock lock(lock_);
- SecurityStateMap::iterator it = security_state_.find(child_id);
- if (it == security_state_.end())
- return; // May be called multiple times.
-
- delete it->second;
- security_state_.erase(it);
+ security_state_.erase(child_id);
worker_map_.erase(child_id);
}
@@ -790,7 +783,7 @@ void ChildProcessSecurityPolicyImpl::AddChild(int child_id) {
return;
}
- security_state_[child_id] = new SecurityState();
+ security_state_[child_id] = base::MakeUnique<SecurityState>();
}
bool ChildProcessSecurityPolicyImpl::ChildProcessHasPermissionsForFile(
« no previous file with comments | « content/browser/child_process_security_policy_impl.h ('k') | content/browser/renderer_host/p2p/socket_dispatcher_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698