Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: content/browser/appcache/appcache_storage.cc

Issue 2249473002: Remove use of stl_util's STLDeleteContainerPairSecondPointers from content/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/appcache/appcache_storage.h" 5 #include "content/browser/appcache/appcache_storage.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/stl_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "content/browser/appcache/appcache_response.h" 10 #include "content/browser/appcache/appcache_response.h"
11 #include "content/browser/appcache/appcache_service_impl.h" 11 #include "content/browser/appcache/appcache_service_impl.h"
12 #include "storage/browser/quota/quota_client.h" 12 #include "storage/browser/quota/quota_client.h"
13 #include "storage/browser/quota/quota_manager_proxy.h" 13 #include "storage/browser/quota/quota_manager_proxy.h"
14 14
15 namespace content { 15 namespace content {
16 16
17 // static 17 // static
18 const int64_t AppCacheStorage::kUnitializedId = -1; 18 const int64_t AppCacheStorage::kUnitializedId = -1;
19 19
20 AppCacheStorage::AppCacheStorage(AppCacheServiceImpl* service) 20 AppCacheStorage::AppCacheStorage(AppCacheServiceImpl* service)
21 : last_cache_id_(kUnitializedId), last_group_id_(kUnitializedId), 21 : last_cache_id_(kUnitializedId), last_group_id_(kUnitializedId),
22 last_response_id_(kUnitializedId), service_(service) { 22 last_response_id_(kUnitializedId), service_(service) {
23 } 23 }
24 24
25 AppCacheStorage::~AppCacheStorage() { 25 AppCacheStorage::~AppCacheStorage() {
26 base::STLDeleteValues(&pending_info_loads_);
27 DCHECK(delegate_references_.empty()); 26 DCHECK(delegate_references_.empty());
28 } 27 }
29 28
30 AppCacheStorage::DelegateReference::DelegateReference( 29 AppCacheStorage::DelegateReference::DelegateReference(
31 Delegate* delegate, AppCacheStorage* storage) 30 Delegate* delegate, AppCacheStorage* storage)
32 : delegate(delegate), storage(storage) { 31 : delegate(delegate), storage(storage) {
33 storage->delegate_references_.insert( 32 storage->delegate_references_.insert(
34 DelegateReferenceMap::value_type(delegate, this)); 33 DelegateReferenceMap::value_type(delegate, this));
35 } 34 }
36 35
37 AppCacheStorage::DelegateReference::~DelegateReference() { 36 AppCacheStorage::DelegateReference::~DelegateReference() {
38 if (delegate) 37 if (delegate)
39 storage->delegate_references_.erase(delegate); 38 storage->delegate_references_.erase(delegate);
40 } 39 }
41 40
42 AppCacheStorage::ResponseInfoLoadTask::ResponseInfoLoadTask( 41 AppCacheStorage::ResponseInfoLoadTask::ResponseInfoLoadTask(
43 const GURL& manifest_url, 42 const GURL& manifest_url,
44 int64_t response_id, 43 int64_t response_id,
45 AppCacheStorage* storage) 44 AppCacheStorage* storage)
46 : storage_(storage), 45 : storage_(storage),
47 manifest_url_(manifest_url), 46 manifest_url_(manifest_url),
48 response_id_(response_id), 47 response_id_(response_id),
49 info_buffer_(new HttpResponseInfoIOBuffer) { 48 info_buffer_(new HttpResponseInfoIOBuffer) {
50 storage_->pending_info_loads_.insert( 49 storage_->pending_info_loads_[response_id] = base::WrapUnique(this);
51 PendingResponseInfoLoads::value_type(response_id, this));
52 } 50 }
53 51
54 AppCacheStorage::ResponseInfoLoadTask::~ResponseInfoLoadTask() { 52 AppCacheStorage::ResponseInfoLoadTask::~ResponseInfoLoadTask() {
55 } 53 }
56 54
57 void AppCacheStorage::ResponseInfoLoadTask::StartIfNeeded() { 55 void AppCacheStorage::ResponseInfoLoadTask::StartIfNeeded() {
58 if (reader_) 56 if (reader_)
59 return; 57 return;
60 reader_.reset(storage_->CreateResponseReader(manifest_url_, response_id_)); 58 reader_.reset(storage_->CreateResponseReader(manifest_url_, response_id_));
61 reader_->ReadInfo(info_buffer_.get(), 59 reader_->ReadInfo(info_buffer_.get(),
62 base::Bind(&ResponseInfoLoadTask::OnReadComplete, 60 base::Bind(&ResponseInfoLoadTask::OnReadComplete,
63 base::Unretained(this))); 61 base::Unretained(this)));
64 } 62 }
65 63
66 void AppCacheStorage::ResponseInfoLoadTask::OnReadComplete(int result) { 64 void AppCacheStorage::ResponseInfoLoadTask::OnReadComplete(int result) {
65 std::unique_ptr<ResponseInfoLoadTask> this_wrapper(
66 std::move(storage_->pending_info_loads_[response_id_]));
67 storage_->pending_info_loads_.erase(response_id_); 67 storage_->pending_info_loads_.erase(response_id_);
68
68 scoped_refptr<AppCacheResponseInfo> info; 69 scoped_refptr<AppCacheResponseInfo> info;
69 if (result >= 0) { 70 if (result >= 0) {
70 info = new AppCacheResponseInfo(storage_, manifest_url_, 71 info = new AppCacheResponseInfo(storage_, manifest_url_,
71 response_id_, 72 response_id_,
72 info_buffer_->http_info.release(), 73 info_buffer_->http_info.release(),
73 info_buffer_->response_data_size); 74 info_buffer_->response_data_size);
74 } 75 }
75 FOR_EACH_DELEGATE(delegates_, OnResponseInfoLoaded(info.get(), response_id_)); 76 FOR_EACH_DELEGATE(delegates_, OnResponseInfoLoaded(info.get(), response_id_));
76 delete this; 77
78 // returning deletes this
77 } 79 }
78 80
79 void AppCacheStorage::LoadResponseInfo(const GURL& manifest_url, 81 void AppCacheStorage::LoadResponseInfo(const GURL& manifest_url,
80 int64_t id, 82 int64_t id,
81 Delegate* delegate) { 83 Delegate* delegate) {
82 AppCacheResponseInfo* info = working_set_.GetResponseInfo(id); 84 AppCacheResponseInfo* info = working_set_.GetResponseInfo(id);
83 if (info) { 85 if (info) {
84 delegate->OnResponseInfoLoaded(info, id); 86 delegate->OnResponseInfoLoaded(info, id);
85 return; 87 return;
86 } 88 }
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 if (service()->quota_manager_proxy() && 129 if (service()->quota_manager_proxy() &&
128 usage_map_.find(origin) != usage_map_.end()) 130 usage_map_.find(origin) != usage_map_.end())
129 service()->quota_manager_proxy()->NotifyStorageAccessed( 131 service()->quota_manager_proxy()->NotifyStorageAccessed(
130 storage::QuotaClient::kAppcache, 132 storage::QuotaClient::kAppcache,
131 origin, 133 origin,
132 storage::kStorageTypeTemporary); 134 storage::kStorageTypeTemporary);
133 } 135 }
134 136
135 } // namespace content 137 } // namespace content
136 138
OLDNEW
« no previous file with comments | « content/browser/appcache/appcache_storage.h ('k') | content/browser/child_process_security_policy_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698