Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: icu52/patches/vscomp.patch

Issue 224943002: icu local change part1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/
Patch Set: function indentation changed Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « icu52/patches/vs2012.patch ('k') | icu52/patches/wpo.patch » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: icu52/patches/vscomp.patch
===================================================================
--- icu52/patches/vscomp.patch (revision 261238)
+++ icu52/patches/vscomp.patch (working copy)
@@ -1,69 +1,39 @@
-Index: source/common/normalizer2impl.h
-===================================================================
---- source/common/normalizer2impl.h (revision 73520)
-+++ source/common/normalizer2impl.h (working copy)
-@@ -31,7 +31,7 @@
-
- U_NAMESPACE_BEGIN
-
--class CanonIterData;
-+struct CanonIterData;
-
- class Hangul {
- public:
Index: source/common/locmap.c
===================================================================
---- source/common/locmap.c (revision 73520)
+--- source/common/locmap.c (revision 259715)
+++ source/common/locmap.c (working copy)
-@@ -30,9 +30,11 @@
+@@ -29,6 +29,7 @@
#include "cstring.h"
#include "cmemory.h"
+#if 0
- #if defined(U_WINDOWS) && defined(_MSC_VER) && (_MSC_VER >= 1500)
+ #if U_PLATFORM == U_PF_WINDOWS && defined(_MSC_VER) && (_MSC_VER >= 1500)
+ /*
+ * TODO: It seems like we should widen this to
+@@ -40,6 +41,7 @@
+ */
#define USE_WINDOWS_LOCALE_API
#endif
+#endif
#ifdef USE_WINDOWS_LOCALE_API
#include <windows.h>
-Index: source/common/putil.c
+Index: source/common/stringpiece.cpp
===================================================================
---- source/common/putil.c (revision 73520)
-+++ source/common/putil.c (working copy)
-@@ -2159,7 +2159,7 @@
-
- if(U_FAILURE(*status)) return NULL;
-
-- lib = LoadLibrary(libName);
-+ lib = LoadLibraryA(libName);
-
- if(lib==NULL) {
- *status = U_MISSING_RESOURCE_ERROR;
-Index: source/i18n/zstrfmt.h
-===================================================================
---- source/i18n/zstrfmt.h (revision 73520)
-+++ source/i18n/zstrfmt.h (working copy)
-@@ -80,7 +80,7 @@
- * ZSFStringPool Pool of (UChar *) strings. Provides for sharing of repeated
- * strings within ZoneStringFormats.
- */
--class ZSFStringPoolChunk;
-+struct ZSFStringPoolChunk;
- class ZSFStringPool: public UMemory {
- public:
- ZSFStringPool(UErrorCode &status);
-Index: source/i18n/fmtable.cpp
-===================================================================
---- source/i18n/fmtable.cpp (revision 73520)
-+++ source/i18n/fmtable.cpp (working copy)
-@@ -199,6 +199,9 @@
- // -------------------------------------
- // copy constructor
+--- source/common/stringpiece.cpp (revision 259715)
++++ source/common/stringpiece.cpp (working copy)
+@@ -68,6 +68,14 @@
+ }
-+#ifdef U_WINODWS
-+#pragram warning(disable: 4996)
+
++/* Microsoft Visual Studio (even 2013) complains about redefinition of this
++ * static const class variable. However, the C++ standard states that this
++ * definition is correct. Perhaps there is a bug in the Microsoft compiler.
++ * This is not an issue on any other compilers (that we know of).
++ * Cygwin with MSVC 9.0 also complains here about redefinition.
++ */
++#if (!defined(_MSC_VER) || (_MSC_VER > 1800)) && !defined(CYGWINMSVC)
+ const int32_t StringPiece::npos = 0x7fffffff;
+#endif
- Formattable::Formattable(const Formattable &source)
- : UObject(*this)
+ U_NAMESPACE_END
« no previous file with comments | « icu52/patches/vs2012.patch ('k') | icu52/patches/wpo.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698