Do not immediately block cross-renderer extension resource loads for non-web-triggered transitions

extensions/browser/url_request_util.cc

Index: extensions/browser/url_request_util.cc
diff --git a/extensions/browser/url_request_util.cc b/extensions/browser/url_request_util.cc
index 2450fa3e32eae6287d72999f3eee7b32c30a133b..1e44115bcb7c545ff28353e4785ae75006b309c7 100644
--- a/extensions/browser/url_request_util.cc
+++ b/extensions/browser/url_request_util.cc
@@ -49,7 +49,8 @@ bool AllowCrossRendererResourceLoad(net::URLRequest* request,
     return true;
   }
 
-  if (!ui::PageTransitionIsWebTriggerable(info->GetPageTransition())) {
+  if (is_guest &&

[Devlin, 2016/08/18 16:58:40]

we should add a comment explaining this.

+      !ui::PageTransitionIsWebTriggerable(info->GetPageTransition())) {

[Devlin, 2016/08/18 16:58:40]

let's cache this in bool is_web_triggerable_transition.

     *allowed = false;
     return true;
   }
@@ -118,6 +119,11 @@ bool AllowCrossRendererResourceLoad(net::URLRequest* request,
     return true;
   }
 
+  if (!ui::PageTransitionIsWebTriggerable(info->GetPageTransition())) {

[Devlin, 2016/08/18 16:58:40]

and a comment/todo for this (especially if you think it should be removed).

+    *allowed = false;
+    return true;
+  }
+
   // Couldn't determine if the resource is allowed or not.
   return false;
 }