Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2249413005: recipe_autoroller: pass cwd=workdir directly, not using a context (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

recipe_autoroller: pass cwd=workdir directly, not using a context TBR=emso,sergiyb,tandrii BUG=620494 Committed: https://chromium.googlesource.com/infra/infra/+/42a8fd2ca80f47ddf0deae45671d6339d781efa8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M recipes/recipe_modules/recipe_autoroller/api.py View 3 chunks +4 lines, -4 lines 0 comments Download
M recipes/recipes/recipe_autoroller.expected/basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/recipes/recipe_autoroller.expected/empty.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/recipes/recipe_autoroller.expected/failed_upload.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/recipes/recipe_autoroller.expected/failure.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/recipes/recipe_autoroller.expected/nontrivial.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/recipes/recipe_autoroller.expected/previously_uploaded.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/recipes/recipe_autoroller.expected/previously_uploaded_match.json View 2 chunks +0 lines, -2 lines 0 comments Download
M recipes/recipes/recipe_autoroller.expected/repo_data_nontrivial_open.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/recipes/recipe_autoroller.expected/repo_data_trivial_closed.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/recipes/recipe_autoroller.expected/repo_data_trivial_cq.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/recipes/recipe_autoroller.expected/with_auth.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249413005/1
4 years, 4 months ago (2016-08-18 13:04:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/infra/infra/+/42a8fd2ca80f47ddf0deae45671d6339d781efa8
4 years, 4 months ago (2016-08-18 13:18:04 UTC) #5
Paweł Hajdan Jr.
TBR
4 years, 4 months ago (2016-08-18 13:24:16 UTC) #7
tandrii(chromium)
lgtm
4 years, 4 months ago (2016-08-18 13:25:26 UTC) #8
Sergiy Byelozyorov
4 years, 3 months ago (2016-08-31 11:02:21 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698