src/hydrogen-dce.cc - Issue 22494003: Allow HPhis to have an invalid merge index.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-dce.cc

Issue 22494003: Allow HPhis to have an invalid merge index. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix comment. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen-dce.cc

diff --git a/src/hydrogen-dce.cc b/src/hydrogen-dce.cc

index 4ad32d2e4c8968d03781e5bf67e618ef6b14fb2d..0e7253d5a4869d44ee137129bd4c037eb8774dfd 100644

--- a/src/hydrogen-dce.cc

+++ b/src/hydrogen-dce.cc

@@ -118,7 +118,9 @@ void HDeadCodeEliminationPhase::RemoveDeadInstructions() {

HPhi* phi = worklist.RemoveLast();

HBasicBlock* block = phi->block();

phi->DeleteAndReplaceWith(NULL);

- block->RecordDeletedPhi(phi->merged_index());

+ if (phi->HasMergedIndex()) {

+ block->RecordDeletedPhi(phi->merged_index());

+ }

}

« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-escape-analysis.cc » ('j') | no next file with comments »