Issue 22494003: Allow HPhis to have an invalid merge index.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22494003: Allow HPhis to have an invalid merge index. (Closed)

Created:
7 years, 4 months ago by Michael Starzinger

Modified:
7 years, 4 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Allow HPhis to have an invalid merge index. All phis that do not represent local variables or values on the operand stack are not allowed to carry a merge index, as the replay of the HEnvironment during LChunkBuilder time might get out of sync due to colliding indexes. R=danno@chromium.org BUG=v8:2815 Committed: http://code.google.com/p/v8/source/detail?r=16135

Patch Set 1 #

Patch Set 2 : Fix comment. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -54 lines)			Patch
M	src/arm/lithium-arm.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/hydrogen.h	View		8 chunks	+25 lines, -29 lines	0 comments	Download
M	src/hydrogen.cc	View		10 chunks	+22 lines, -14 lines	0 comments	Download
M	src/hydrogen-dce.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/hydrogen-escape-analysis.cc	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1	3 chunks	+5 lines, -1 line	0 comments	Download
M	src/hydrogen-osr.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/mips/lithium-mips.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

7 years, 4 months ago (2013-08-09 15:18:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16135 (presubmit successful).

Expand Messages | Collapse Messages