Prevent peripheral mode operation from outside of Kiosk.

Prevent peripheral mode operation from outside of Kiosk.

Peripheral mode is only supposed to work with auto-launched apps in a
Kiosk session. This check wasn't put in the API when this was first
implemented but we should fix this ASAP.

R=xiyuan@chromium.org,ortuno@chromium.org
BUG=638460
Committed: https://crrev.com/94e2a8816e090d944a8248ea3a4d526ffc49dd4a
Cr-Commit-Position: refs/heads/master@{#412718}

[rkc, 2016-08-17 02:28:20]

Description was changed from

==========
Prevent peripheral mode operation from outside of Kiosk.

Peripheral mode is only supposed to work with auto-launched apps in a
Kiosk session. This check wasn't put in the API when this was first
implemented but we should fix this ASAP.


R=xiyuan@chromium.org
BUG=638460
==========

to

==========
Prevent peripheral mode operation from outside of Kiosk.

Peripheral mode is only supposed to work with auto-launched apps in a
Kiosk session. This check wasn't put in the API when this was first
implemented but we should fix this ASAP.


R=xiyuan@chromium.org
BUG=638460
==========

[rkc, 2016-08-17 02:28:41]

rkc@chromium.org changed reviewers:
+ ortuno@chromium.org

[rkc, 2016-08-17 02:28:55]

Description was changed from

==========
Prevent peripheral mode operation from outside of Kiosk.

Peripheral mode is only supposed to work with auto-launched apps in a
Kiosk session. This check wasn't put in the API when this was first
implemented but we should fix this ASAP.


R=xiyuan@chromium.org
BUG=638460
==========

to

==========
Prevent peripheral mode operation from outside of Kiosk.

Peripheral mode is only supposed to work with auto-launched apps in a
Kiosk session. This check wasn't put in the API when this was first
implemented but we should fix this ASAP.


R=xiyuan@chromium.org,ortuno@chromium.org
BUG=638460
==========

[xiyuan, 2016-08-17 16:37:30]

lgtm

https://codereview.chromium.org/2249333002/diff/1/chrome/test/data/extensions...
File
chrome/test/data/extensions/api_test/bluetooth_low_energy/create_service_kiosk_session_only/runtest.js
(right):

https://codereview.chromium.org/2249333002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/bluetooth_low_energy/create_service_kiosk_session_only/runtest.js:12:
chrome.test.fail("Should not work outside of kiosk mode");
nit: Update the error message since this failure is expected in kiosk session
that is not auto launched.

[rkc, 2016-08-17 23:10:15]

https://codereview.chromium.org/2249333002/diff/1/chrome/test/data/extensions...
File
chrome/test/data/extensions/api_test/bluetooth_low_energy/create_service_kiosk_session_only/runtest.js
(right):

https://codereview.chromium.org/2249333002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/bluetooth_low_energy/create_service_kiosk_session_only/runtest.js:12:
chrome.test.fail("Should not work outside of kiosk mode");
On 2016/08/17 16:37:29, xiyuan wrote:
> nit: Update the error message since this failure is expected in kiosk session
> that is not auto launched.

Fixed here and in register_advertisement_kiosk_mode_only.
Done.

[rkc, 2016-08-17 23:10:36]

The CQ bit was checked by rkc@chromium.org

[rkc, 2016-08-17 23:10:36]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2249333002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-08-17 23:11:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 01:28:39]

Description was changed from

==========
Prevent peripheral mode operation from outside of Kiosk.

Peripheral mode is only supposed to work with auto-launched apps in a
Kiosk session. This check wasn't put in the API when this was first
implemented but we should fix this ASAP.


R=xiyuan@chromium.org,ortuno@chromium.org
BUG=638460
==========

to

==========
Prevent peripheral mode operation from outside of Kiosk.

Peripheral mode is only supposed to work with auto-launched apps in a
Kiosk session. This check wasn't put in the API when this was first
implemented but we should fix this ASAP.


R=xiyuan@chromium.org,ortuno@chromium.org
BUG=638460
==========

[commit-bot: I haz the power, 2016-08-18 01:28:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-18 01:30:10]

Description was changed from

==========
Prevent peripheral mode operation from outside of Kiosk.

Peripheral mode is only supposed to work with auto-launched apps in a
Kiosk session. This check wasn't put in the API when this was first
implemented but we should fix this ASAP.


R=xiyuan@chromium.org,ortuno@chromium.org
BUG=638460
==========

to

==========
Prevent peripheral mode operation from outside of Kiosk.

Peripheral mode is only supposed to work with auto-launched apps in a
Kiosk session. This check wasn't put in the API when this was first
implemented but we should fix this ASAP.

R=xiyuan@chromium.org,ortuno@chromium.org
BUG=638460

Committed: https://crrev.com/94e2a8816e090d944a8248ea3a4d526ffc49dd4a
Cr-Commit-Position: refs/heads/master@{#412718}
==========

[commit-bot: I haz the power, 2016-08-18 01:30:11]

Patchset 2 (id:??) landed as
https://crrev.com/94e2a8816e090d944a8248ea3a4d526ffc49dd4a
Cr-Commit-Position: refs/heads/master@{#412718}