Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: git_cl.py

Issue 2249303003: Fix bug in git cl status and add logging. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 6658a2fa05aaf149ac417453e4643cf1e6a9b1f4..399f9ed0369b7dab7c35cf548cd779b08ee353c1 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -3063,14 +3063,20 @@ def get_cl_statuses(changes, fine_grained, max_processes=None):
# Process one branch synchronously to work through authentication, then
# spawn processes to process all the other branches in parallel.
if changes:
- fetch = lambda cl: (cl, cl.GetStatus())
+ def fetch(cl):
+ try:
+ return (cl, cl.GetStatus())
+ except:
+ # See http://crbug.com/629863.
+ logging.exception('failed to fetch status for %s:', cl)
+ raise
yield fetch(changes[0])
- if not changes:
+ changes_to_fetch = changes[1:]
+ if not changes_to_fetch:
# Exit early if there was only one branch to fetch.
return
- changes_to_fetch = changes[1:]
pool = ThreadPool(
min(max_processes, len(changes_to_fetch))
if max_processes is not None
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698