Simplify Observer callbacks

Simplify Observer callbacks

We can merge the OnSucceeded, OnFailed, and OnRemoved callbacks into a
single OnCompleted callback, with a status to differentiate the
disposition of the request.

BUG=610521
Committed: https://crrev.com/75839979d7219aa27bf0bba1674e35f3a9c07106
Cr-Commit-Position: refs/heads/master@{#412394}

[Pete Williamson, 2016-08-16 21:50:06]

petewil@chromium.org changed reviewers:
+ fgorski@chromium.org

[Pete Williamson, 2016-08-16 21:52:38]

The CQ bit was checked by petewil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 21:52:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-08-16 22:13:25]

lgtm

https://codereview.chromium.org/2249303002/diff/1/components/offline_pages/ba...
File components/offline_pages/background/request_coordinator.h (right):

https://codereview.chromium.org/2249303002/diff/1/components/offline_pages/ba...
components/offline_pages/background/request_coordinator.h:38: enum class
SavePageStatus {
nit: SavePageStatus might no longer be the best name for this enum.
Consider a TODO. I'd vote for CompletionStatus (but as part of a different CL)

https://codereview.chromium.org/2249303002/diff/1/components/offline_pages/ba...
components/offline_pages/background/request_coordinator.h:58: // TODO(petewil):
Merge OnSucceeded, OnFailed, and OnRemoved into a single
remove todo

[commit-bot: I haz the power, 2016-08-16 22:40:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 22:40:39]

Dry run: This issue passed the CQ dry run.

[Pete Williamson, 2016-08-16 22:58:44]

The CQ bit was checked by petewil@chromium.org

[Pete Williamson, 2016-08-16 22:58:44]

The patchset sent to the CQ was uploaded after l-g-t-m from fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/2249303002/#ps20001
(title: "CR nits - fix TODOs")

[commit-bot: I haz the power, 2016-08-16 22:59:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Pete Williamson, 2016-08-16 23:08:52]

https://codereview.chromium.org/2249303002/diff/1/components/offline_pages/ba...
File components/offline_pages/background/request_coordinator.h (right):

https://codereview.chromium.org/2249303002/diff/1/components/offline_pages/ba...
components/offline_pages/background/request_coordinator.h:38: enum class
SavePageStatus {
On 2016/08/16 22:13:25, fgorski wrote:
> nit: SavePageStatus might no longer be the best name for this enum.
> Consider a TODO. I'd vote for CompletionStatus (but as part of a different CL)

Done.

https://codereview.chromium.org/2249303002/diff/1/components/offline_pages/ba...
components/offline_pages/background/request_coordinator.h:58: // TODO(petewil):
Merge OnSucceeded, OnFailed, and OnRemoved into a single
On 2016/08/16 22:13:25, fgorski wrote:
> remove todo

Done.

[commit-bot: I haz the power, 2016-08-17 00:21:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-17 00:22:56]

Description was changed from

==========
Simplify Observer callbacks

We can merge the OnSucceeded, OnFailed, and OnRemoved callbacks into a
single OnCompleted callback, with a status to differentiate the
disposition of the request.

BUG=610521
==========

to

==========
Simplify Observer callbacks

We can merge the OnSucceeded, OnFailed, and OnRemoved callbacks into a
single OnCompleted callback, with a status to differentiate the
disposition of the request.

BUG=610521

Committed: https://crrev.com/75839979d7219aa27bf0bba1674e35f3a9c07106
Cr-Commit-Position: refs/heads/master@{#412394}
==========

[commit-bot: I haz the power, 2016-08-17 00:22:58]

Patchset 2 (id:??) landed as
https://crrev.com/75839979d7219aa27bf0bba1674e35f3a9c07106
Cr-Commit-Position: refs/heads/master@{#412394}

[dougarnett, 2016-08-19 20:59:23]

dougarnett@chromium.org changed reviewers:
+ dougarnett@chromium.org

[dougarnett, 2016-08-19 20:59:24]

https://codereview.chromium.org/2249303002/diff/20001/components/offline_page...
File components/offline_pages/background/request_coordinator.h (right):

https://codereview.chromium.org/2249303002/diff/20001/components/offline_page...
components/offline_pages/background/request_coordinator.h:38: // TODO(petewil):
Can we find a better name for this enum?
BackgroundSavePageResult or SavePageLaterResult ?