Issue 22493010: policy: load JSON schema into domain descriptor at start time.

Issue 22493010: policy: load JSON schema into domain descriptor at start time. (Closed)

Created:
7 years, 4 months ago by dconnelly

Modified:
7 years ago

Reviewers:
Joao da Silva

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

policy: load JSON schema into domain descriptor at start time. This is CL 2 of 3 that loads policy on Windows using the schema. The global Chrome policy domain descriptor containing the policy JSON schema is created by the BrowserPolicyConnector and registered with the policy providers before triggering a policy load. Depends on https://codereview.chromium.org/22364011/ BUG=270667

Patch Set 1 #

Patch Set 2 : read schema from function to decouple CLs #

Patch Set 3 : rebase and fix unit tests #

Patch Set 4 : add comments and clean up includes #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -20 lines)			Patch
M	chrome/browser/policy/async_policy_loader.h	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/async_policy_loader.cc	View	1 2	2 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/policy/async_policy_provider.h	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/async_policy_provider.cc	View	1 2	3 chunks	+10 lines, -2 lines	0 comments	Download
M	chrome/browser/policy/async_policy_provider_unittest.cc	View	1 2	1 chunk	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/policy/browser_policy_connector.cc	View	1 2 3	5 chunks	+16 lines, -9 lines	1 comment	Download
M	chrome/browser/policy/configuration_policy_provider.h	View	1 2 3	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_provider.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/mock_policy_service.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/policy_domain_descriptor.cc	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/policy/policy_service.h	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/policy_service_impl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/policy_service_impl.cc	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

7 years, 3 months ago (2013-09-11 13:32:02 UTC) #2

The overhead of parsing the schema should not be incurred upon non-enterprise
users; it should be lazily loaded, or should be loaded from a format generated
at compile time that makes parsing much faster.

Let's put this on hold until we have better ideas for that.

https://codereview.chromium.org/22493010/diff/9015/chrome/browser/policy/brow...
File chrome/browser/policy/browser_policy_connector.cc (right):

https://codereview.chromium.org/22493010/diff/9015/chrome/browser/policy/brow...
chrome/browser/policy/browser_policy_connector.cc:333: CHECK(err == "") << err;
CHECK(schema) << err

Expand Messages | Collapse Messages