Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3744)

Unified Diff: blimp/client/session/blimp_client_session.cc

Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lai
Patch Set: Addresses nyquist's #9 comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/session/blimp_client_session.cc
diff --git a/blimp/client/session/blimp_client_session.cc b/blimp/client/session/blimp_client_session.cc
index d20654f3852d1358afeb652c6e1e32ac201139f5..a47a47c1516ca7ff9c1cb8b0964cccb43c40a591 100644
--- a/blimp/client/session/blimp_client_session.cc
+++ b/blimp/client/session/blimp_client_session.cc
@@ -19,6 +19,8 @@
#include "blimp/client/core/blimp_client_switches.h"
#include "blimp/client/core/contents/navigation_feature.h"
#include "blimp/client/core/contents/tab_control_feature.h"
+#include "blimp/client/core/geolocation/blimp_location_provider.h"
+#include "blimp/client/core/geolocation/geolocation_feature.h"
#include "blimp/client/core/session/client_network_components.h"
#include "blimp/client/core/session/cross_thread_network_event_observer.h"
#include "blimp/client/feature/ime_feature.h"
@@ -37,6 +39,8 @@ namespace client {
BlimpClientSession::BlimpClientSession(const GURL& assigner_endpoint)
: io_thread_("BlimpIOThread"),
+ geolocation_feature_(
Kevin M 2016/08/19 17:51:37 This is also contained in the ClientContext? O_o
CJ 2016/08/19 20:44:01 Acknowledged.
+ new GeolocationFeature(base::MakeUnique<BlimpLocationProvider>())),
tab_control_feature_(new TabControlFeature),
navigation_feature_(new NavigationFeature),
ime_feature_(new ImeFeature),
@@ -127,6 +131,9 @@ void BlimpClientSession::RegisterFeatures() {
settings_feature_.get()));
thread_pipe_manager_->RegisterFeature(BlimpMessage::kBlobChannel,
blob_delegate_);
+ geolocation_feature_->set_outgoing_message_processor(
+ thread_pipe_manager_->RegisterFeature(BlimpMessage::kGeolocation,
+ geolocation_feature_.get()));
// Client will not send send any RenderWidget messages, so don't save the
// outgoing BlimpMessageProcessor in the RenderWidgetFeature.

Powered by Google App Engine
This is Rietveld 408576698