Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: blimp/engine/app/blimp_permission_manager.cc

Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lai
Patch Set: In response to Wez's #48 comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/app/blimp_permission_manager.cc
diff --git a/blimp/engine/app/blimp_permission_manager.cc b/blimp/engine/app/blimp_permission_manager.cc
index 6f48b00325aa4ba6d5a8315d4b0ccc2ca6859eca..1e1d3865e679cb4b9d03ffe0f2059b57486a789f 100644
--- a/blimp/engine/app/blimp_permission_manager.cc
+++ b/blimp/engine/app/blimp_permission_manager.cc
@@ -23,7 +23,13 @@ int BlimpPermissionManager::RequestPermission(
const GURL& origin,
bool user_gesture,
const base::Callback<void(blink::mojom::PermissionStatus)>& callback) {
- callback.Run(blink::mojom::PermissionStatus::DENIED);
+ if (permission == content::PermissionType::GEOLOCATION) {
+ VLOG(1) << "Permission requested and granted.";
Kevin M 2016/09/01 20:01:07 "Geolocation permission granted"
CJ 2016/09/01 22:59:42 Done.
+ callback.Run(blink::mojom::PermissionStatus::GRANTED);
+ } else {
+ VLOG(1) << "Permission requested and denied.";
Kevin M 2016/09/01 20:01:06 Log |permission|?
CJ 2016/09/01 22:59:42 It's an enum class.
+ callback.Run(blink::mojom::PermissionStatus::DENIED);
+ }
return kNoPendingOperation;
}

Powered by Google App Engine
This is Rietveld 408576698