blimp/client/core/BUILD.gn - Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/BUILD.gn

Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lai

Patch Set: In response to Wez's #48 comments. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/app/android/AndroidManifest.xml.jinja2 ('k') | blimp/client/core/blimp_client_context_impl.h » ('j') | blimp/client/core/blimp_client_context_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/BUILD.gn

diff --git a/blimp/client/core/BUILD.gn b/blimp/client/core/BUILD.gn

index df933ea787321819427c34218bfdfdbe7bc16f61..d6e46f56e6fec78f6a853e376c2511e762f1af8b 100644

--- a/blimp/client/core/BUILD.gn

+++ b/blimp/client/core/BUILD.gn

@@ -102,11 +102,13 @@ source_set("context") {

"//blimp/client/core/contents",

"//blimp/client/core/session",

"//blimp/client/public:public_headers",

+ "//device/geolocation:device_geolocation",

"//url",

]

deps = [

":switches",

+ "//blimp/client/core/geolocation",

"//blimp/client/core/settings",

]

@@ -167,6 +169,7 @@ if (is_android) {

":switches_java",

"//blimp/client/core/contents:contents_java",

"//blimp/client/core/settings:settings_java",

+ "//device/geolocation:geolocation_java",

]

}