device/geolocation/geolocation_provider_impl.cc - Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/geolocation/geolocation_provider_impl.cc

Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lai

Patch Set: Addresses nyquist's #46 comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc ('K') | « device/geolocation/BUILD.gn ('k') | device/geolocation/location_arbitrator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/geolocation/geolocation_provider_impl.cc

diff --git a/device/geolocation/geolocation_provider_impl.cc b/device/geolocation/geolocation_provider_impl.cc

index dde10c0a4440586e959d9fd9bc74666c7b6aa2c6..4c7e51c3ebabe70122d1626dab8aae5023f5f57f 100644

--- a/device/geolocation/geolocation_provider_impl.cc

+++ b/device/geolocation/geolocation_provider_impl.cc

@@ -17,7 +17,7 @@

#include "base/single_thread_task_runner.h"

#include "base/threading/thread_task_runner_handle.h"

#include "device/geolocation/geolocation_delegate.h"

-#include "device/geolocation/location_arbitrator_impl.h"

+#include "device/geolocation/location_arbitrator.h"

namespace device {

@@ -190,8 +190,7 @@ void GeolocationProviderImpl::Init() {

if (!g_delegate.Get())

g_delegate.Get().reset(new GeolocationDelegate);

- arbitrator_ =

- base::MakeUnique<LocationArbitratorImpl>(g_delegate.Get().get());

+ arbitrator_ = base::MakeUnique<LocationArbitrator>(g_delegate.Get().get());

arbitrator_->SetUpdateCallback(callback);

}