device/geolocation/BUILD.gn - Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/geolocation/BUILD.gn

Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lai

Patch Set: Addresses nyquist's #32 comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/session/blimp_client_session.cc ('K') | « blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc ('k') | device/geolocation/geolocation_provider_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/geolocation/BUILD.gn

diff --git a/device/geolocation/BUILD.gn b/device/geolocation/BUILD.gn

index 58bc49cceb5cd2d36ccfc2d0f74e09663c029ae9..c6f23787b1257dcf09b48c029968951018bb749e 100644

--- a/device/geolocation/BUILD.gn

+++ b/device/geolocation/BUILD.gn

@@ -31,8 +31,8 @@ component("device_geolocation") {

"geoposition.h",

"location_api_adapter_android.cc",

"location_api_adapter_android.h",

- "location_arbitrator_impl.cc",

- "location_arbitrator_impl.h",

+ "location_arbitrator.cc",

+ "location_arbitrator.h",

"location_provider.h",

"location_provider_android.cc",

"location_provider_android.h",

@@ -171,7 +171,7 @@ source_set("unittests") {

sources = [

"geolocation_provider_impl_unittest.cc",

- "location_arbitrator_impl_unittest.cc",

+ "location_arbitrator_unittest.cc",

"network_location_provider_unittest.cc",

"wifi_data_provider_chromeos_unittest.cc",

"wifi_data_provider_common_unittest.cc",