blimp/engine/feature/geolocation/engine_geolocation_feature.h - Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/feature/geolocation/engine_geolocation_feature.h

Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lai

Patch Set: Addresses nyquist's #32 comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/session/blimp_client_session.cc ('K') | « blimp/engine/app/blimp_permission_manager.cc ('k') | blimp/engine/feature/geolocation/engine_geolocation_feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/engine/feature/geolocation/engine_geolocation_feature.h

diff --git a/blimp/engine/feature/geolocation/engine_geolocation_feature.h b/blimp/engine/feature/geolocation/engine_geolocation_feature.h

index 4219db03ebd54581a03516b8a9dca50b4ac97bec..e1bbb447d1c8d4ed54740d81dd5d2b5bb7478af5 100644

--- a/blimp/engine/feature/geolocation/engine_geolocation_feature.h

+++ b/blimp/engine/feature/geolocation/engine_geolocation_feature.h

@@ -44,9 +44,11 @@ class EngineGeolocationFeature : public BlimpMessageProcessor,

GeolocationSetInterestLevelMessage::Level level) override;

void OnPermissionGranted() override;

void SetUpdateCallback(const GeopositionReceivedCallback& callback) override;

+ void SetTaskRunner(scoped_refptr<base::SingleThreadTaskRunner> runner);

std::unique_ptr<BlimpMessageProcessor> outgoing_message_processor_;

GeopositionReceivedCallback geoposition_received_callback_;

+ scoped_refptr<base::SingleThreadTaskRunner> task_runner_;

base::WeakPtrFactory<EngineGeolocationFeature> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(EngineGeolocationFeature);