Hooks together Geolocation Feature in the Client and Engine.

blimp/client/core/blimp_client_context_impl.h

Index: blimp/client/core/blimp_client_context_impl.h
diff --git a/blimp/client/core/blimp_client_context_impl.h b/blimp/client/core/blimp_client_context_impl.h
index 355dddeb45fca4b5264b7aa2ddeb4f1d454cc0ee..67b59922433bdb3a98d67b3819cb2a65166e0821 100644
--- a/blimp/client/core/blimp_client_context_impl.h
+++ b/blimp/client/core/blimp_client_context_impl.h
@@ -6,6 +6,7 @@
 #define BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_
 
 #include <memory>
+#include <string>

[nyquist, 2016/09/01 00:34:30]

thanks!

 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
@@ -19,6 +20,7 @@
 #include "blimp/client/public/contents/blimp_contents.h"
 #include "blimp/client/public/session/assignment.h"
 #include "blimp/net/thread_pipe_manager.h"
+#include "device/geolocation/geolocation_delegate.h"

[nyquist, 2016/09/01 00:34:30]

can this be forward declared?

[CJ, 2016/09/01 00:45:40]

Done.

 #include "url/gurl.h"
 
 namespace blimp {
@@ -27,6 +29,7 @@ namespace client {
 class BlimpCompositorDependencies;
 class BlimpContentsManager;
 class CompositorDependencies;
+class GeolocationFeature;
 class ImeFeature;
 class NavigationFeature;
 class RenderWidgetFeature;
@@ -99,7 +102,10 @@ class BlimpClientContextImpl : public BlimpClientContext,
   // A set of dependencies required by all BlimpCompositor instances.
   std::unique_ptr<BlimpCompositorDependencies> blimp_compositor_dependencies_;
 
+  std::unique_ptr<device::GeolocationDelegate> geolocation_delegate_;

[nyquist, 2016/09/01 00:34:30]

Could you have a quick comment here as to what this delegate is for?

[CJ, 2016/09/01 00:45:40]

Done.

+
   // Features to handle all incoming and outgoing protobuf messages.
+  std::unique_ptr<GeolocationFeature> geolocation_feature_;
   std::unique_ptr<ImeFeature> ime_feature_;
   std::unique_ptr<NavigationFeature> navigation_feature_;
   std::unique_ptr<RenderWidgetFeature> render_widget_feature_;