blimp/client/core/blimp_client_context_impl.cc - Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/blimp_client_context_impl.cc

Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lai

Patch Set: Addresses kmarshall's #16 comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/core/blimp_client_context_impl.h ('K') | « blimp/client/core/blimp_client_context_impl.h ('k') | blimp/client/core/geolocation/BUILD.gn » ('j') | device/geolocation/rate_limiting_location_provider_proxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/blimp_client_context_impl.cc

diff --git a/blimp/client/core/blimp_client_context_impl.cc b/blimp/client/core/blimp_client_context_impl.cc

index f90b1dc02b222929b3e0851a1a240809064d7aa0..a8175ee82034c24b63ea368b96376a8cf8142cc7 100644

--- a/blimp/client/core/blimp_client_context_impl.cc

+++ b/blimp/client/core/blimp_client_context_impl.cc

@@ -4,6 +4,8 @@

#include "blimp/client/core/blimp_client_context_impl.h"

+#include <string>

#include "base/bind.h"

#include "base/memory/ptr_util.h"

#include "base/message_loop/message_loop.h"

@@ -59,7 +61,7 @@ BlimpClientContextImpl::BlimpClientContextImpl(

thread_pipe_manager_ = base::MakeUnique<ThreadPipeManager>(

io_thread_task_runner_, net_components_->GetBrowserConnectionHandler());

- // Initialize must only be posted after the calls features have been

+ // Initialize must only be posted after the features have been

// registered.

io_thread_task_runner_->PostTask(

FROM_HERE, base::Bind(&ClientNetworkComponents::Initialize,