blimp/client/BUILD.gn - Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/BUILD.gn

Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lai

Patch Set: Addresses kmarshall's #16 comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/client/BUILD.gn

diff --git a/blimp/client/BUILD.gn b/blimp/client/BUILD.gn

index 8c536ea8b5ecca4f9354073b3ee1d7d2e412d1b0..9718112d86712acef19232c1d91fcd23370ee60c 100644

--- a/blimp/client/BUILD.gn

+++ b/blimp/client/BUILD.gn

@@ -18,6 +18,8 @@ source_set("session") {

public_deps = [

":feature",

"//blimp/client/core:switches",

+ "//blimp/client/core/geolocation",

+ "//device/geolocation:device_geolocation",

"//ui/events",

]

@@ -108,6 +110,7 @@ source_set("feature") {

"//cc",

"//cc/proto",

"//components/url_formatter",

+ "//device/geolocation:device_geolocation",

"//net:net",

"//skia",

"//ui/base/ime:text_input_types",

« no previous file with comments | « no previous file | blimp/client/DEPS » ('j') | blimp/client/core/blimp_client_context_impl.h » ('J')