blimp/client/session/blimp_client_session.h - Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/session/blimp_client_session.h

Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lai

Patch Set: Addresses Wez's #14 comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/core/blimp_client_context_impl.h ('K') | « blimp/client/core/geolocation/BUILD.gn ('k') | blimp/client/session/blimp_client_session.cc » ('j') | device/geolocation/location_arbitrator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/session/blimp_client_session.h

diff --git a/blimp/client/session/blimp_client_session.h b/blimp/client/session/blimp_client_session.h

index aaccdd832ecf85c380a4c75e5cf0f15ab8c05c8c..0553652a93ae241eee85a04bdebad77d1f3ee186 100644

--- a/blimp/client/session/blimp_client_session.h

+++ b/blimp/client/session/blimp_client_session.h

@@ -13,6 +13,7 @@

#include "base/memory/weak_ptr.h"

#include "base/threading/thread.h"

#include "blimp/client/core/compositor/blob_image_serialization_processor.h"

+#include "blimp/client/core/geolocation/geolocation_feature.h"

#include "blimp/client/core/session/assignment_source.h"

#include "blimp/client/core/session/network_event_observer.h"

#include "blimp/client/public/session/assignment.h"

@@ -103,6 +104,7 @@ class BlimpClientSession

BlobImageSerializationProcessor blob_image_processor_;

std::unique_ptr<BlobChannelReceiver> blob_receiver_;

+ std::unique_ptr<GeolocationFeature> geolocation_feature_;

std::unique_ptr<TabControlFeature> tab_control_feature_;

std::unique_ptr<NavigationFeature> navigation_feature_;

std::unique_ptr<ImeFeature> ime_feature_;