Hooks together Geolocation Feature in the Client and Engine.

blimp/client/core/geolocation/blimp_location_provider.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BLIMP_CLIENT_CORE_GEOLOCATION_BLIMP_LOCATION_PROVIDER_H_
+#define BLIMP_CLIENT_CORE_GEOLOCATION_BLIMP_LOCATION_PROVIDER_H_
+
+#include <memory>
+
+#include "device/geolocation/geolocation_delegate.h"
+#include "device/geolocation/geoposition.h"
+#include "device/geolocation/location_provider.h"
+
+namespace blimp {
+namespace client {
+
+// Client-side location provider that handles frequency of geolocation updates.
+class BlimpLocationProvider : public device::LocationProvider {

[Kevin M, 2016/08/19 17:51:37]

Perhaps we could provide it with a more descriptive name, e.g.
RateLimitingLocationProviderProxy? Something like that... the "Blimp" class
prefix is superfluous for several reasons (namespace, dir structure)

* "handles frequency" isn't descriptive, either.
* Add TODO indicating that the scheduling aspect still needs to be implemented.

[CJ, 2016/08/19 20:44:01]

Done.

[Wez, 2016/08/19 23:12:10]

This class is a pure LocationProvider proxy - it doesn't implement any behaviour
- so why not just use the LocationArbitratorImpl directly for now?

Even when we do make this a rate-limiting proxy, it doesn't seem that that will
be particularly Blimp-specific, so it may make more sense to have a
RateLimitedLocationProvider in device/gelocation/

WDYT?

[CJ, 2016/08/22 20:28:08]

I agree with moving it over to device/geolocation.

I'm trying to make CL's a bit smaller, so that's why it doesn't have much going
for it yet. Basic tests can be made for the class, and will make the next
checkin hopefully smoother. 

+ public:
+  BlimpLocationProvider();
+  ~BlimpLocationProvider() override;
+
+  // LocationProvider implemenation.
+  void SetUpdateCallback(
+      const LocationProviderUpdateCallback& callback) override;
+  bool StartProvider(bool enable_high_accuracy) override;
+  void StopProvider() override;
+  const device::Geoposition& GetPosition() override;
+  void OnPermissionGranted() override;
+
+ private:
+  void OnLocationUpdate(const device::Geoposition& new_position);

[Kevin M, 2016/08/19 17:51:37]

Comment this method

[CJ, 2016/08/19 20:44:01]

Done.

+
+  std::unique_ptr<device::LocationProvider> location_provider_;
+  LocationProvider::LocationProviderUpdateCallback feature_update_callback_;
+
+  DISALLOW_COPY_AND_ASSIGN(BlimpLocationProvider);
+};
+
+}  // namespace client
+}  // namespace blimp
+
+#endif  // BLIMP_CLIENT_CORE_GEOLOCATION_BLIMP_LOCATION_PROVIDER_H_