Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: blimp/client/core/blimp_client_context_impl.h

Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lai
Patch Set: Addresses Wez's #14 comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_ 5 #ifndef BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_
6 #define BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_ 6 #define BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string>
9 10
10 #include "base/macros.h" 11 #include "base/macros.h"
11 #include "base/memory/ref_counted.h" 12 #include "base/memory/ref_counted.h"
12 #include "base/memory/weak_ptr.h" 13 #include "base/memory/weak_ptr.h"
13 #include "base/single_thread_task_runner.h" 14 #include "base/single_thread_task_runner.h"
14 #include "base/threading/thread.h" 15 #include "base/threading/thread.h"
15 #include "blimp/client/core/session/client_network_components.h" 16 #include "blimp/client/core/session/client_network_components.h"
16 #include "blimp/client/core/session/network_event_observer.h" 17 #include "blimp/client/core/session/network_event_observer.h"
17 #include "blimp/client/public/blimp_client_context.h" 18 #include "blimp/client/public/blimp_client_context.h"
18 #include "blimp/client/public/contents/blimp_contents.h" 19 #include "blimp/client/public/contents/blimp_contents.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 // Returns the URL to use for connections to the assigner. Used to construct 53 // Returns the URL to use for connections to the assigner. Used to construct
53 // the AssignmentSource. 54 // the AssignmentSource.
54 virtual GURL GetAssignerURL(); 55 virtual GURL GetAssignerURL();
55 56
56 private: 57 private:
57 // The AssignmentCallback for when an assignment is ready. This will trigger 58 // The AssignmentCallback for when an assignment is ready. This will trigger
58 // a connection to the engine. 59 // a connection to the engine.
59 virtual void ConnectWithAssignment(AssignmentRequestResult result, 60 virtual void ConnectWithAssignment(AssignmentRequestResult result,
60 const Assignment& assignment); 61 const Assignment& assignment);
61 62
63 // Register features' message senders and receivers.
Kevin M 2016/08/22 22:09:34 Function no longer exists in the .cc; remove this
CJ 2016/08/23 18:07:13 Done.
64 void RegisterFeatures();
65
62 // Provides functionality from the embedder. 66 // Provides functionality from the embedder.
63 BlimpClientContextDelegate* delegate_ = nullptr; 67 BlimpClientContextDelegate* delegate_ = nullptr;
64 68
65 // The task runner to use for IO operations. 69 // The task runner to use for IO operations.
66 scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner_; 70 scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner_;
67 71
68 // The task runner to use for file operations. 72 // The task runner to use for file operations.
69 scoped_refptr<base::SingleThreadTaskRunner> file_thread_task_runner_; 73 scoped_refptr<base::SingleThreadTaskRunner> file_thread_task_runner_;
70 74
71 // The AssignmentSource is used when the user of BlimpClientContextImpl calls 75 // The AssignmentSource is used when the user of BlimpClientContextImpl calls
72 // Connect() to get a valid assignment and later connect to the engine. 76 // Connect() to get a valid assignment and later connect to the engine.
73 std::unique_ptr<AssignmentSource> assignment_source_; 77 std::unique_ptr<AssignmentSource> assignment_source_;
74 78
75 std::unique_ptr<BlimpContentsManager> blimp_contents_manager_; 79 std::unique_ptr<BlimpContentsManager> blimp_contents_manager_;
76 80
81 // TODO(lethalantidote): Add unique_ptr to GeolocationFeature and
82 // register it.
83
77 // Container struct for network components. 84 // Container struct for network components.
78 // Must be deleted on the IO thread. 85 // Must be deleted on the IO thread.
79 std::unique_ptr<ClientNetworkComponents> net_components_; 86 std::unique_ptr<ClientNetworkComponents> net_components_;
80 87
81 std::unique_ptr<ThreadPipeManager> thread_pipe_manager_; 88 std::unique_ptr<ThreadPipeManager> thread_pipe_manager_;
82 89
83 base::WeakPtrFactory<BlimpClientContextImpl> weak_factory_; 90 base::WeakPtrFactory<BlimpClientContextImpl> weak_factory_;
84 91
85 DISALLOW_COPY_AND_ASSIGN(BlimpClientContextImpl); 92 DISALLOW_COPY_AND_ASSIGN(BlimpClientContextImpl);
86 }; 93 };
87 94
88 } // namespace client 95 } // namespace client
89 } // namespace blimp 96 } // namespace blimp
90 97
91 #endif // BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_ 98 #endif // BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698