Remove dip scale dependency from ui::WindowAndroid

Remove dip scale dependency from ui::WindowAndroid

Starting from Android N dip scale can be changed dynamically.
In this CL we remove the dip scale impliciltly stored in
WindowAndroid's |content_offset_| and use the scale at the
time of calculations that involve the content offset.

This is a prerequisite for https://codereview.chromium.org/2202123002/

BUG=620929
Committed: https://crrev.com/164e1eecb22e6c1d5a004666bff8ca8d0b127e34
Cr-Commit-Position: refs/heads/master@{#412653}

[Tima Vaisburd, 2016-08-16 20:53:52]

timav@chromium.org changed reviewers:
+ boliu@chromium.org, gsennton@chromium.org, sievers@chromium.org,
tedchoc@chromium.org

[Tima Vaisburd, 2016-08-16 20:53:53]

PTAL

[no sievers, 2016-08-17 19:21:02]

https://codereview.chromium.org/2249243002/diff/20001/content/browser/android...
File content/browser/android/content_view_core_impl.cc (right):

https://codereview.chromium.org/2249243002/diff/20001/content/browser/android...
content/browser/android/content_view_core_impl.cc:218:
dpi_scale_(ui::GetScaleFactorForNativeView(&view_)),
so can this be removed now?

[Tima Vaisburd, 2016-08-17 19:28:39]

https://codereview.chromium.org/2249243002/diff/20001/content/browser/android...
File content/browser/android/content_view_core_impl.cc (right):

https://codereview.chromium.org/2249243002/diff/20001/content/browser/android...
content/browser/android/content_view_core_impl.cc:218:
dpi_scale_(ui::GetScaleFactorForNativeView(&view_)),
On 2016/08/17 19:21:02, sievers wrote:
> so can this be removed now?

This CL only does a small cleanup wrt set_content_offset().

In the next CL which adds the method that sets |dpi_scale_| we can always set it
with the method instead of assigning initial value here and replacing it by
set_dpi_scale().

[boliu, 2016-08-17 19:32:38]

https://codereview.chromium.org/2249243002/diff/20001/content/browser/android...
File content/browser/android/content_view_core_impl.cc (right):

https://codereview.chromium.org/2249243002/diff/20001/content/browser/android...
content/browser/android/content_view_core_impl.cc:218:
dpi_scale_(ui::GetScaleFactorForNativeView(&view_)),
On 2016/08/17 19:28:38, Tima Vaisburd wrote:
> On 2016/08/17 19:21:02, sievers wrote:
> > so can this be removed now?
> 
> This CL only does a small cleanup wrt set_content_offset().
> 
> In the next CL which adds the method that sets |dpi_scale_| we can always set
it
> with the method instead of assigning initial value here and replacing it by
> set_dpi_scale().

the question is can dpi_scale_ be removed, and the answer is no because
dpi_scale() is still called from a bunch of places

also just noticed the typo here, it should be dip, not dpi :p

[no sievers, 2016-08-17 19:33:37]

On 2016/08/17 19:32:38, boliu wrote:
>
https://codereview.chromium.org/2249243002/diff/20001/content/browser/android...
> File content/browser/android/content_view_core_impl.cc (right):
> 
>
https://codereview.chromium.org/2249243002/diff/20001/content/browser/android...
> content/browser/android/content_view_core_impl.cc:218:
> dpi_scale_(ui::GetScaleFactorForNativeView(&view_)),
> On 2016/08/17 19:28:38, Tima Vaisburd wrote:
> > On 2016/08/17 19:21:02, sievers wrote:
> > > so can this be removed now?
> > 
> > This CL only does a small cleanup wrt set_content_offset().
> > 
> > In the next CL which adds the method that sets |dpi_scale_| we can always
set
> it
> > with the method instead of assigning initial value here and replacing it by
> > set_dpi_scale().
> 
> the question is can dpi_scale_ be removed, and the answer is no because
> dpi_scale() is still called from a bunch of places
> 
> also just noticed the typo here, it should be dip, not dpi :p

oops, missed the private getter method. lgtm.

[no sievers, 2016-08-17 19:34:00]

On 2016/08/17 19:33:37, sievers wrote:
> On 2016/08/17 19:32:38, boliu wrote:
> >
>
https://codereview.chromium.org/2249243002/diff/20001/content/browser/android...
> > File content/browser/android/content_view_core_impl.cc (right):
> > 
> >
>
https://codereview.chromium.org/2249243002/diff/20001/content/browser/android...
> > content/browser/android/content_view_core_impl.cc:218:
> > dpi_scale_(ui::GetScaleFactorForNativeView(&view_)),
> > On 2016/08/17 19:28:38, Tima Vaisburd wrote:
> > > On 2016/08/17 19:21:02, sievers wrote:
> > > > so can this be removed now?
> > > 
> > > This CL only does a small cleanup wrt set_content_offset().
> > > 
> > > In the next CL which adds the method that sets |dpi_scale_| we can always
> set
> > it
> > > with the method instead of assigning initial value here and replacing it
by
> > > set_dpi_scale().
> > 
> > the question is can dpi_scale_ be removed, and the answer is no because
> > dpi_scale() is still called from a bunch of places
> > 
> > also just noticed the typo here, it should be dip, not dpi :p
> 
> oops, missed the private getter method. lgtm.

modulo Bo's typo comment

[boliu, 2016-08-17 19:35:16]

On 2016/08/17 19:34:00, sievers wrote:
> On 2016/08/17 19:33:37, sievers wrote:
> > On 2016/08/17 19:32:38, boliu wrote:
> > >
> >
>
https://codereview.chromium.org/2249243002/diff/20001/content/browser/android...
> > > File content/browser/android/content_view_core_impl.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2249243002/diff/20001/content/browser/android...
> > > content/browser/android/content_view_core_impl.cc:218:
> > > dpi_scale_(ui::GetScaleFactorForNativeView(&view_)),
> > > On 2016/08/17 19:28:38, Tima Vaisburd wrote:
> > > > On 2016/08/17 19:21:02, sievers wrote:
> > > > > so can this be removed now?
> > > > 
> > > > This CL only does a small cleanup wrt set_content_offset().
> > > > 
> > > > In the next CL which adds the method that sets |dpi_scale_| we can
always
> > set
> > > it
> > > > with the method instead of assigning initial value here and replacing it
> by
> > > > set_dpi_scale().
> > > 
> > > the question is can dpi_scale_ be removed, and the answer is no because
> > > dpi_scale() is still called from a bunch of places
> > > 
> > > also just noticed the typo here, it should be dip, not dpi :p
> > 
> > oops, missed the private getter method. lgtm.
> 
> modulo Bo's typo comment

Let's fix the typo in another CL, since it's not introduced in this CL

[Ted C, 2016-08-17 20:21:16]

lgtm

[Tima Vaisburd, 2016-08-17 20:57:47]

The CQ bit was checked by timav@chromium.org

[commit-bot: I haz the power, 2016-08-17 20:58:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 21:46:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-17 21:51:03]

Description was changed from

==========
Remove dip scale dependency from ui::WindowAndroid

Starting from Android N dip scale can be changed dynamically.
In this CL we remove the dip scale impliciltly stored in
WindowAndroid's |content_offset_| and use the scale at the
time of calculations that involve the content offset.

This is a prerequisite for https://codereview.chromium.org/2202123002/

BUG=620929
==========

to

==========
Remove dip scale dependency from ui::WindowAndroid

Starting from Android N dip scale can be changed dynamically.
In this CL we remove the dip scale impliciltly stored in
WindowAndroid's |content_offset_| and use the scale at the
time of calculations that involve the content offset.

This is a prerequisite for https://codereview.chromium.org/2202123002/

BUG=620929

Committed: https://crrev.com/164e1eecb22e6c1d5a004666bff8ca8d0b127e34
Cr-Commit-Position: refs/heads/master@{#412653}
==========

[commit-bot: I haz the power, 2016-08-17 21:51:04]

Patchset 2 (id:??) landed as
https://crrev.com/164e1eecb22e6c1d5a004666bff8ca8d0b127e34
Cr-Commit-Position: refs/heads/master@{#412653}