Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: test/codegen/language/async_await_test.dart

Issue 2249233002: fix #626, add AMD module format and make it default (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: merged Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/browser/runtime_tests.js ('k') | test/codegen/sunflower/sunflower.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/codegen/language/async_await_test.dart
diff --git a/test/codegen/language/async_await_test.dart b/test/codegen/language/async_await_test.dart
index 791f22b863d0ffeb20baca39977ec8f0a70ddbef..2694008049b7b4c06e467617a7b8abf4b04b528a 100644
--- a/test/codegen/language/async_await_test.dart
+++ b/test/codegen/language/async_await_test.dart
@@ -1536,11 +1536,12 @@ main() {
});
// Equality and identity.
- test("Identical and equals", () {
+ // TODO(jmesserly): https://github.com/dart-lang/dev_compiler/issues/265
+ skip_test("Identical and equals", () {
expect(async.instanceMethod, equals(async.instanceMethod));
expect(Async.staticMethod, same(Async.staticMethod));
expect(topMethod, same(topMethod));
- }, skip: 'https://github.com/dart-lang/dev_compiler/issues/265');
+ });
});
group("await expression", () {
@@ -1623,13 +1624,14 @@ main() {
return expect42(f());
});
- test("suffix operator + pre-increment", () {
+ // TODO(jmesserly): https://github.com/dart-lang/dev_compiler/issues/265
+ skip_test("suffix operator + pre-increment", () {
f() async {
var v = [41];
return await ++v[0];
}
return expect42(f());
- }, skip: 'https://github.com/dart-lang/dev_compiler/issues/267');
+ });
test("assignment operator", () {
f() async {
@@ -1963,8 +1965,8 @@ Future syncInAsync(f) async {
class FakeValueFuture implements Future {
final _value;
FakeValueFuture(this._value);
- Future/*<S>*/ then/*<S>*/(/*=S*/ callback(value), {Function onError}) {
- return new Future<dynamic /*=S*/>.microtask(() => callback(_value));
+ Future/*<S>*/ then/*<S>*/(callback(value), {Function onError}) {
+ return new Future/*<S>*/.microtask(() => callback(_value));
}
Future whenComplete(callback()) {
return new Future.microtask(() { callback(); });
@@ -1982,7 +1984,7 @@ typedef BinaryFunction(a, b);
class FakeErrorFuture implements Future {
final _error;
FakeErrorFuture(this._error);
- Future/*<S>*/ then/*<S>*/(/*=S*/ callback(value), {Function onError}) {
+ Future/*<S>*/ then/*<S>*/(callback(value), {Function onError}) {
if (onError != null) {
if (onError is BinaryFunction) {
return new Future/*<S>*/.microtask(() => onError(_error, null));
« no previous file with comments | « test/browser/runtime_tests.js ('k') | test/codegen/sunflower/sunflower.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698